From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DB4A42914; Tue, 11 Apr 2023 16:48:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C2BC40DFD; Tue, 11 Apr 2023 16:48:56 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 107C240C35 for ; Tue, 11 Apr 2023 16:48:54 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 926175C0054; Tue, 11 Apr 2023 10:48:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 11 Apr 2023 10:48:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1681224531; x=1681310931; bh=f4azq75y6OG2cTyhF4VaPxVxtz4D+5WGvHN Z9uU6WiA=; b=L9GwVvQGcRfbZi+0AkdF1ad6fwo37YRVEosEqaARu5rftHutgin N7LN5/f6xSk71L09ZDaorYPr0UPuX8kGa/H4kRAQoZfHCMPI33FONkC0OrLGSxmx 7KI0Nhi5jJjMaXYXVF+h6Scip+cIu3XMwKsgZUWC7XhXYiIpWr6YqesK57b2h2I2 p3ubGPAK0nbpVIbgxhUOBZaGEEp4q+u5QWnM50noaG3G2+e5lxAX5mlUAfVKw1DF 8aqA2ND7x7dKN2l/WZqwUYgkJuHzPiKxL/ntApdTBHtKbJQAZjj/K6O1A0K37EJH fbY2/fUJQD2H+EGtRiWkhZTfTu9y1Iq45fw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681224531; x=1681310931; bh=f4azq75y6OG2cTyhF4VaPxVxtz4D+5WGvHN Z9uU6WiA=; b=SybE/sAPVoTyqKfo/ef84njds30OyFTVtSVSd5x8dXvVod2YmND 6wBlrBCJOIS5SdStWZTrPgPQQsbRTdKN29BL17o7N2yMo7So+dd7L91HamZ2Qt7O GEd1EfX37gqE7h005PvPeWLbbp7aqwPui6ZamK8efI+2uygFR45HbqSba7fb7jbO dzJAwyZkBRP0jc191SvzpVcow3V9jwfpNOuznQXPc47U+GAEC+gSroqE4Fod+azG tp1dsZ+hFrMKJAQAFX8W3Pv0nWvRIThnPrsI0wT2q9QEL5XtUNb7ce3Qbwk3bzU6 ZvKHo3TyeUuJhaL4JC+FuNqpYROWKiluIzA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekgedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedthfffteehhfektedtjeekhfelgfeffeehfefhudevjeejleei heetkeduvdelueenucffohhmrghinhepphihthhhohhnqdhpohgvthhrhidrohhrghenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgr shesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Apr 2023 10:48:49 -0400 (EDT) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= Cc: wathsala.vithanage@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, Honnappa.Nagarahalli@arm.com, lijuan.tu@intel.com, bruce.richardson@intel.com, dev@dpdk.org Subject: Re: [PATCH v1 1/2] dts: fabric requirements Date: Tue, 11 Apr 2023 16:48:47 +0200 Message-ID: <5667444.DvuYhMxLoT@thomas> In-Reply-To: References: <20230403114608.1423020-1-juraj.linkes@pantheon.tech> <7872319.mogB4TqSGs@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 04/04/2023 13:51, Juraj Linke=C5=A1: > On Mon, Apr 3, 2023 at 5:18=E2=80=AFPM Thomas Monjalon wrote: >=20 > > 03/04/2023 16:56, Juraj Linke=C5=A1: > > > On Mon, Apr 3, 2023 at 2:33=E2=80=AFPM Thomas Monjalon > > wrote: > > > > > > > 03/04/2023 13:46, Juraj Linke=C5=A1: > > > > > Replace pexpect with Fabric. > > > > > > > > You should squash these lines with the move to Fabric. > > > > > > > > > Signed-off-by: Juraj Linke=C5=A1 > > > > > --- > > > > > dts/poetry.lock | 553 > > +++++++++++++++++++++++++++++++++++++++------ > > > > > > > > Do we really need *all* these lines? > > > > I see a lot of lines about Windows and MacOSX which are not support= ed > > in > > > > DTS. > > > > It is so long that it looks impossible to review. > > > > > > > > > > > This is a generated file and doesn't need to be reviewed. > > > > In general, I don't like storing generated files. > > >=20 > Me neither, but this one is specifically designed to be stored in a > repository: > https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-t= o-version-control >=20 >=20 > > > > > I separated the > > > dependencies part so that the code part is easier to review. If you > > want, I > > > can squash the two commits. > > > > What happens if we manually remove the useless lines? > > > > > The lock file is there so that everyone installs exactly the same versions > of dependencies. We can specify the versions of dependencies in > pyproject.toml, but we won't control the versions of dependencies of > dependencies this way. If we remove the changes to the lock file, then we > won't be storing tested versions, everyone would be using slightly > different versions and we may potentially need to address versioning issu= es > in the future - best to prevent that with a lock file. You didn't answer about removing the usuless lines, like unneeded Windows s= upport.