From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmatilai@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 6FB5C8E7B
 for <dev@dpdk.org>; Fri, 11 Dec 2015 10:05:16 +0100 (CET)
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
 (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
 by mx1.redhat.com (Postfix) with ESMTPS id 34395C07567D;
 Fri, 11 Dec 2015 09:05:15 +0000 (UTC)
Received: from sopuli.koti.laiskiainen.org (vpn1-4-166.ams2.redhat.com
 [10.36.4.166])
 by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 tBB95DrT010787; Fri, 11 Dec 2015 04:05:14 -0500
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "Iremonger, Bernard" <bernard.iremonger@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
References: <1449749971-5422-1-git-send-email-bernard.iremonger@intel.com>
 <1449755601-25670-1-git-send-email-bernard.iremonger@intel.com>
 <2601191342CEEE43887BDE71AB97725836AD25A2@irsmsx105.ger.corp.intel.com>
From: Panu Matilainen <pmatilai@redhat.com>
Message-ID: <566A91C9.5040500@redhat.com>
Date: Fri, 11 Dec 2015 11:05:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <2601191342CEEE43887BDE71AB97725836AD25A2@irsmsx105.ger.corp.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23
Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of
 hugepages needed
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Dec 2015 09:05:16 -0000

On 12/10/2015 04:50 PM, Ananyev, Konstantin wrote:
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger
>> Sent: Thursday, December 10, 2015 1:53 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of hugepages needed
>>
>> Change MAX_QUEUES from 512 to 128 to reduce the number of hugepages
>> required by the vhost-switch program.
>>
>> Changes in v2:
>> remove comment added before #define MAX_QUEUES in v1 patch.
>>
>> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
>> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>
>
> Wasn't it increased a while ago, because someone complained that
> 128 queues might not be enough on FVL?
>  From git log I can see that it was first increased from 128 to 256,
> then from 256 to 512.
> The reason mentioned - HW that has bigger number of queues.
> Isn't it not the case anymore?
> If yes, why?
>
> BTW, shouldn't it be then at least:
>
> +#ifndef MAX_QUEUES
> +#define MAX_QUEUES 128
> +#endif
>
> So people can just do -D MAX_QUEUES=X at build time if they like(need) to.

Being subject to constant changes back and forth suggests this really 
should be a runtime tunable rather than build time constant.

	- Panu -