From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1AA538E72 for ; Fri, 11 Dec 2015 10:28:51 +0100 (CET) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 5F2F28E71F; Fri, 11 Dec 2015 09:28:50 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-166.ams2.redhat.com [10.36.4.166]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBB9SmsQ031659; Fri, 11 Dec 2015 04:28:49 -0500 To: Stephen Hemminger , dev@dpdk.org References: <1449790022-24126-1-git-send-email-stephen@networkplumber.org> From: Panu Matilainen Message-ID: <566A9750.7070507@redhat.com> Date: Fri, 11 Dec 2015 11:28:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1449790022-24126-1-git-send-email-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Subject: Re: [dpdk-dev] [PATCH] doc: announce API change for rte_ether.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Dec 2015 09:28:51 -0000 On 12/11/2015 01:27 AM, Stephen Hemminger wrote: > Plan to change to version of struct ether_addr in > DPDK 2.3. The change in DPDK source is trivial but it will impact > source compatablilty therefore notification is necessary. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/rel_notes/deprecation.rst | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 1c7ab01..8ecb990 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -19,3 +19,8 @@ Deprecation Notices > and table action handlers will be updated: > the pipeline parameter will be added, the packets mask parameter will be > either removed (for input port action handler) or made input-only. > + > +* librte_ether: The structure ether_addr in DPDK will be replaced > + by using the standard header file . The structure > + size will be the same (no ABI impact), but the structure field name > + will change from addr_bytes[] to ether_addr_octet[]. > I hope there is some other reason/benefit besides getting rid of a three-line custom struct definition. It may be a trivial s/addr_bytes/ether_addr_octet/ change but it touches a lot of places all over the DPDK codebase alone, and for 3rd party developers such (at least seemingly) gratuitous renames are really irritating. - Panu -