From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A335A0547; Fri, 28 May 2021 09:20:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 922AD40143; Fri, 28 May 2021 09:20:39 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 9244340040 for ; Fri, 28 May 2021 09:20:38 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A51065C0178; Fri, 28 May 2021 03:20:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 28 May 2021 03:20:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= s10H2jDaCdnHD2wBFcba4vB2DFlizB1sde0h7Vaw1TM=; b=3bAga2Y2CH69xV0b VxT1tRsZiK7UOrUVU9VIqxQmLAo+iQdjwQdkX6LC+Ew0D44gNZbsYNlG6ogIziFI SKvfUxpoGwrpEObn2EYVeAVEXCLbL+uhmyGwCbkDJUv860h6NAdb2fwausRJzjch /6bFBLq+faZBOuelYaPX3mMvsVpodPrck2HGGOA8bRn3Xgr4J8OxJvnIgWerPd+U 53VDhlziRfFTQyE/55CvKK6zvArdpcPtlOE5OFuMtUNDH9ij7qRAJcrBRdTQVdaE Cz1T1yC9TPgVRkF//F7ye7+Dvb13v4HdxKn2OrGJ2k3XQhcIt6pHz/238eUHD9wZ 8mkpjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=s10H2jDaCdnHD2wBFcba4vB2DFlizB1sde0h7Vaw1 TM=; b=lqlxd2G8hcgydWZYTTT7p8mCAMfyxcDuh4K1xJNavhQj70w606bapCWVL NUUmMb7lWKMzYabbllkHSPc8UlH2/0KRfCTk3mm3s/zwOAwvzDjc1Sb5SO7K3aUF Ks5z8CH3gu0lwOx4eJiePpX9/2zLD1NGAIEeZk4sXSRiV/O14R6nWOHiA6ZVquOL oqyD5NnAbGQ6uNx2Bbysss/l1vnAWvnjOjgQ8OdRqz9ubFlW3UHirGYLA0wXF43a 2Vb3G7x0kaMUGibiIFIKWoZ4PuJHrRrSe/RT6vNNPg3sDJ9G1HGM7dcjpk9EzMkC /+x4W2VMP0opnAD+B+Xg/LyJf4qKQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdekiedguddujecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdev uedtjeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 May 2021 03:20:34 -0400 (EDT) From: Thomas Monjalon To: "Somalapuram, Amaranath" Cc: David Marchand , dev , Akhil Goyal , "Kumar, Ravi1" , "Song, Keesang" Date: Fri, 28 May 2021 09:20:32 +0200 Message-ID: <5674266.VGimov99b0@thomas> In-Reply-To: References: <20200128083819.32834-1-asomalap@amd.com> <4362836.01VGQip8NV@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] crypto/ccp: enable IOMMU for CCP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/05/2021 07:02, Somalapuram, Amaranath: > From: Thomas Monjalon > > 27/05/2021 15:24, David Marchand: > > > On Fri, Dec 25, 2020 at 9:06 AM wrote: > > > > From: Amaranath Somalapuram > > > >=20 > > > > CCP use vdev framework, and vdev framework don=E2=80=99t support IO= MMU. > > > > Adding custom IOMMU support for AMD CCP driver. > > >=20 > > > I am currently looking at pci bus patches/cleanups. > > > I ended up looking at crypto/ccp. > > > This driver code contains a lot of features duplicated with the pci b= us. > > >=20 > > > Why is the ccp driver not a PCI driver? > >=20 > > Indeed it looks abusing vdev. > > We should drop all the code duplicating the PCI bus driver. > > If nothing else is done, it would mean breaking the probing of this > > driver. > >=20 > > Adding more people in Cc list to have a fix before it is broken, thanks. >=20 > Enable IOMMU for vdev was not supported in DPDK. > I can remove all the duplicating code after I test the CCP with IOMMU. I think you didn't get it. It should not be a vdev. We want to switch the driver to a true PCI device, and remove all the code copied from the PCI bus driver.