From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93B2AA0544; Tue, 21 Jun 2022 03:38:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B74B4069C; Tue, 21 Jun 2022 03:38:16 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id 788D040151 for ; Tue, 21 Jun 2022 03:38:14 +0200 (CEST) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LRpzl55SpzDsJj; Tue, 21 Jun 2022 09:37:39 +0800 (CST) Received: from [127.0.0.1] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 21 Jun 2022 09:38:11 +0800 Subject: Re: [PATCH v8 1/4] ethdev: support device error recovery notification To: Thomas Monjalon CC: , , , , , , References: <20220128124830.427-1-kalesh-anakkur.purayil@broadcom.com> <20220616094122.1909-1-fengchengwen@huawei.com> <20220616094122.1909-2-fengchengwen@huawei.com> <9930820.VV5PYv0bhD@thomas> From: fengchengwen Message-ID: <5676fdec-6c1b-c968-5a46-e487ad315939@huawei.com> Date: Tue, 21 Jun 2022 09:38:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <9930820.VV5PYv0bhD@thomas> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, On 2022/6/21 1:42, Thomas Monjalon wrote: > 16/06/2022 11:41, Chengwen Feng: >> --- a/lib/ethdev/rte_ethdev.h >> +++ b/lib/ethdev/rte_ethdev.h >> @@ -3928,6 +3928,12 @@ enum rte_eth_event_type { >> * @see rte_eth_rx_avail_thresh_set() >> */ >> RTE_ETH_EVENT_RX_AVAIL_THRESH, >> + /** Port recovering from a hardware or firmware error */ >> + RTE_ETH_EVENT_ERR_RECOVERING, >> + /** Port recovers successful from the error */ >> + RTE_ETH_EVENT_RECOVER_SUCCESS, >> + /** Port recovers failed from the error */ >> + RTE_ETH_EVENT_RECOVER_FAILED, >> RTE_ETH_EVENT_MAX /**< max value of this enum */ >> }; > > The descriptions here are not enough. > We cannot understand what has changed on the port, > and which action must be taken. There are detail descriptions in /doc/guides/prog_guide/poll_mode_drv.rst, I will add your review in poll_mode_drv.rst. Another question: do we need to add a detail description here as well? I think the poll_mode_drv.rst is enough. > > Note: I believe that's the same problem from the beginning: > we need a generic handling which is described in details. > > > > . >