Re: [dpdk-dev] [PATCH 1/3] eal: add --dev-hotplug option

[Jeff Guo <jia.guo@intel.com>]

hi, david

On 12/17/2018 6:15 PM, David Marchand wrote:
>
> On Fri, Dec 14, 2018 at 8:41 AM Jeff Guo <jia.guo@intel.com 
> <mailto:jia.guo@intel.com>> wrote:
>
>     This command-line option will enable hotplug event detecting and
>     enable
>     hotplug handling for device hotplug.
>
>     Signed-off-by: Jeff Guo <jia.guo@intel.com <mailto:jia.guo@intel.com>>
>
>
> Is there a reason why we would want this disabled by default and 
> enabled via option ?
>
>

Before i can give you an answer, let's see what will bring on if enable it.

When enable the hotplug will means that it will bring a new netlink 
socket communication

and a sigbus detecting and specific processing. So if user not want to 
add this work load, just

let it to be optional. Do you agree with that? If not please show what 
is your concern. Thanks.


>     diff --git a/lib/librte_eal/common/eal_options.h
>     b/lib/librte_eal/common/eal_options.h
>     index 5271f94..4d8a12e 100644
>     --- a/lib/librte_eal/common/eal_options.h
>     +++ b/lib/librte_eal/common/eal_options.h
>     @@ -65,7 +65,9 @@ enum {
>             OPT_SINGLE_FILE_SEGMENTS_NUM,
>      #define OPT_IOVA_MODE          "iova-mode"
>             OPT_IOVA_MODE_NUM,
>     -       OPT_LONG_MAX_NUM
>     +       OPT_LONG_MAX_NUM,
>     +#define OPT_DEV_HOTPLUG              "dev-hotplug"
>     +       OPT_DEV_HOTPLUG_NUM,
>      };
>
>      extern const char eal_short_options[];
>
>
> OPT_LONG_MAX_NUM is supposed to be the last enum.
>
> -- 
> David Marchand