From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C6FCB4CA9 for ; Sat, 29 Dec 2018 05:06:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Dec 2018 20:06:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,412,1539673200"; d="scan'208,217";a="305919712" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.44]) ([10.67.68.44]) by fmsmga006.fm.intel.com with ESMTP; 28 Dec 2018 20:06:47 -0800 To: David Marchand Cc: bernard.iremonger@intel.com, Wenzhuo Lu , shahafs@mellanox.com, thomas@monjalon.net, matan@mellanox.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, dev@dpdk.org, stephen@networkplumber.org, gaetan.rivet@6wind.com, qi.z.zhang@intel.com, arybchenko@solarflare.com, bruce.richardson@intel.com, shaopeng.he@intel.com, anatoly.burakov@intel.com References: <1544773540-89825-1-git-send-email-jia.guo@intel.com> <1544773540-89825-2-git-send-email-jia.guo@intel.com> From: Jeff Guo Message-ID: <567955b0-b4c3-4926-bb8f-c99f6ff5c338@intel.com> Date: Sat, 29 Dec 2018 12:06:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/3] eal: add --dev-hotplug option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Dec 2018 04:06:51 -0000 hi, david On 12/17/2018 6:15 PM, David Marchand wrote: > > On Fri, Dec 14, 2018 at 8:41 AM Jeff Guo > wrote: > > This command-line option will enable hotplug event detecting and > enable > hotplug handling for device hotplug. > > Signed-off-by: Jeff Guo > > > > Is there a reason why we would want this disabled by default and > enabled via option ? > > Before i can give you an answer, let's see what will bring on if enable it. When enable the hotplug will means that it will bring a new netlink socket communication and a sigbus detecting and specific processing. So if user not want to add this work load, just let it to be optional. Do you agree with that? If not please show what is your concern. Thanks. > diff --git a/lib/librte_eal/common/eal_options.h > b/lib/librte_eal/common/eal_options.h > index 5271f94..4d8a12e 100644 > --- a/lib/librte_eal/common/eal_options.h > +++ b/lib/librte_eal/common/eal_options.h > @@ -65,7 +65,9 @@ enum { >         OPT_SINGLE_FILE_SEGMENTS_NUM, >  #define OPT_IOVA_MODE          "iova-mode" >         OPT_IOVA_MODE_NUM, > -       OPT_LONG_MAX_NUM > +       OPT_LONG_MAX_NUM, > +#define OPT_DEV_HOTPLUG              "dev-hotplug" > +       OPT_DEV_HOTPLUG_NUM, >  }; > >  extern const char eal_short_options[]; > > > OPT_LONG_MAX_NUM is supposed to be the last enum. > > -- > David Marchand