From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED7CAA0032; Fri, 1 Oct 2021 09:51:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6793E41109; Fri, 1 Oct 2021 09:51:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 6D1804067A for ; Fri, 1 Oct 2021 09:51:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633074689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LISNirCv3qrIuXOwdNVCj8fb34jh1ipoP25Qtq5IsYc=; b=K/qPDfjJP+FcjDC7xhzXNLBsZQZeoErSEO2mdctHOBUJgN+Ttc8vG6VK0Zn1j/RTaxSXvM PRGVkOcZnqbDWcZciwN75o7PMLwhThD8ZSYcyJhIHhu7Zu20rKv4npVCXImok8tWGlcfNj /LqmtNUf3+NpuPI5Nio0zVkkCcQpeoQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-4ncLzXvKPWSD9wIcwOWoaA-1; Fri, 01 Oct 2021 03:51:28 -0400 X-MC-Unique: 4ncLzXvKPWSD9wIcwOWoaA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 02853814274; Fri, 1 Oct 2021 07:51:27 +0000 (UTC) Received: from [10.39.208.23] (unknown [10.39.208.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A0D5A5F4E7; Fri, 1 Oct 2021 07:51:05 +0000 (UTC) Message-ID: <567c7418-89ca-3689-56c4-8ae0c65389d6@redhat.com> Date: Fri, 1 Oct 2021 09:51:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: "Li, Xiaoyun" , "dev@dpdk.org" , "Xia, Chenbo" , "amorenoz@redhat.com" , "david.marchand@redhat.com" , "andrew.rybchenko@oktetlabs.ru" , "Yigit, Ferruh" , "michaelba@nvidia.com" , "viacheslavo@nvidia.com" Cc: "stable@dpdk.org" , "nelio.laranjeiro@6wind.com" , "yvugenfi@redhat.com" , "ybendito@redhat.com" References: <20210929091701.158047-1-maxime.coquelin@redhat.com> <20210929091701.158047-6-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 5/5] app/testpmd: add missing flow types in port info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiaoyun, On 9/30/21 03:05, Li, Xiaoyun wrote: > Hi > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Wednesday, September 29, 2021 17:17 >> To: dev@dpdk.org; Xia, Chenbo ; >> amorenoz@redhat.com; david.marchand@redhat.com; >> andrew.rybchenko@oktetlabs.ru; Yigit, Ferruh ; >> michaelba@nvidia.com; viacheslavo@nvidia.com; Li, Xiaoyun >> >> Cc: stable@dpdk.org; nelio.laranjeiro@6wind.com; yvugenfi@redhat.com; >> ybendito@redhat.com; Maxime Coquelin >> Subject: [PATCH v3 5/5] app/testpmd: add missing flow types in port info >> >> This patch adds missing IPv6-Ex and GPTU flow types to port info command. > > GTPU not GPTU > >> It also add the same definitions to str2flowtype(), used to configure flow >> director. >> >> Signed-off-by: Maxime Coquelin >> --- >> app/test-pmd/cmdline.c | 4 ++++ >> app/test-pmd/config.c | 4 ++++ >> 2 files changed, 8 insertions(+) >> >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index >> a9efd027c3..259d9cee4e 100644 >> --- a/app/test-pmd/cmdline.c >> +++ b/app/test-pmd/cmdline.c >> @@ -10408,6 +10408,10 @@ str2flowtype(char *string) >> {"ipv6-sctp", RTE_ETH_FLOW_NONFRAG_IPV6_SCTP}, >> {"ipv6-other", RTE_ETH_FLOW_NONFRAG_IPV6_OTHER}, >> {"l2_payload", RTE_ETH_FLOW_L2_PAYLOAD}, >> + {"ipv6-ex", RTE_ETH_FLOW_IPV6_EX}, >> + {"ipv6-tcp-ex", RTE_ETH_FLOW_IPV6_TCP_EX}, >> + {"ipv6-udp-ex", RTE_ETH_FLOW_IPV6_UDP_EX}, >> + {"gptu", RTE_ETH_FLOW_GTPU}, > > "gtpu" > >> }; >> >> for (i = 0; i < RTE_DIM(flowtype_str); i++) { diff --git a/app/test- >> pmd/config.c b/app/test-pmd/config.c index 9a4a0c232b..39deb02950 >> 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -4528,11 +4528,15 @@ flowtype_to_str(uint16_t flow_type) >> {"ipv6-sctp", RTE_ETH_FLOW_NONFRAG_IPV6_SCTP}, >> {"ipv6-other", RTE_ETH_FLOW_NONFRAG_IPV6_OTHER}, >> {"l2_payload", RTE_ETH_FLOW_L2_PAYLOAD}, >> + {"ipv6-ex", RTE_ETH_FLOW_IPV6_EX}, >> + {"ipv6-tcp-ex", RTE_ETH_FLOW_IPV6_TCP_EX}, >> + {"ipv6-udp-ex", RTE_ETH_FLOW_IPV6_UDP_EX}, >> {"port", RTE_ETH_FLOW_PORT}, >> {"vxlan", RTE_ETH_FLOW_VXLAN}, >> {"geneve", RTE_ETH_FLOW_GENEVE}, >> {"nvgre", RTE_ETH_FLOW_NVGRE}, >> {"vxlan-gpe", RTE_ETH_FLOW_VXLAN_GPE}, >> + {"gptu", RTE_ETH_FLOW_GTPU}, > > "gtpu" > >> }; >> >> for (i = 0; i < RTE_DIM(flowtype_str_table); i++) { >> -- >> 2.31.1 > Oops, looks like I really want to rename this protocol. If there are not other comments on the series, I can fix while applying if this is OK for you. Thanks, Maxime