From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C0D001F5 for ; Wed, 26 Jul 2017 07:39:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1324120AC5; Wed, 26 Jul 2017 01:39:30 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 26 Jul 2017 01:39:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=nk4DQXI3ErBvOvO OvNG019KCuX/yFArDJPaUeSUVMRw=; b=MFifufCcmDhX6LAIMBDIezLha19/N5a E/Lh4FzjEuTh5ipOVM8rbAkZd8SSW9pAWOXH/YR1REY3B1DhE3mmmYS4577aXfy0 hIGW6XomBCUdVh7JJoIZFBq9s54RAYzUGJ4NCMY5qaZ75UFnV7eDmWS5EyUuJaxH ZSmfhvtsTd1Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=nk4DQXI3ErBvOvOOvNG019KCuX/yFArDJPaUeSUVMRw=; b=Nf/RQ6KE qytCnqz7Jc5p4ZIxlSdI810GLTZthapGFlPRKCt3uF+DnLOGcgQr+NMr+la5xdbR OspMChteb1Hdel339N67dmU1HYzDh5NUcgpVUu7lhqa212pLIaQ+HopAqba3cbqq h1cng4xhyYSVrYjkmaKGQhQjSmmLFIt3lGeBvXufPfVicYuMxacMMBiZmi+iPEqq tt3Pxcd5bZdXX5I0d+XHTe5BJUwBUwrdQZl6p/Yw+HxtfvI1bP0KhnIDhZUKgvhj VDeq3qJ1rPaNBTQerYxyEySUM7EycTQfctLFBA9Ntp/Uw85cvxVphjR/1oRkQ2LM at4phpA6yEM7iw== X-ME-Sender: X-Sasl-enc: lle2PnHtFCdrKmS12llXjpdW+7ncFbuIskNaJh7FRvyX 1501047569 Received: from xps.localnet (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id A312A7E16E; Wed, 26 Jul 2017 01:39:29 -0400 (EDT) From: Thomas Monjalon To: "Wiles, Keith" Cc: dev@dpdk.org Date: Wed, 26 Jul 2017 08:39:28 +0300 Message-ID: <5680989.RRpAUyPcSC@xps> In-Reply-To: <4FFF6FD7-FAAB-4034-92DC-D1CF27294837@intel.com> References: <20170725222107.23203-1-thomas@monjalon.net> <4FFF6FD7-FAAB-4034-92DC-D1CF27294837@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [pktgen PATCH 0/6] fix compilation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jul 2017 05:39:31 -0000 26/07/2017 06:54, Wiles, Keith: > > > On Jul 25, 2017, at 5:21 PM, Thomas Monjalon wrote: > > > > Some errors were seen when trying to compile with gcc 7 or clang, > > for 32-bit, and with DPDK 17.08-rc2. > > > > Thomas Monjalon (6): > > remove unused functions > > fix screen type saving > > fix compilation of printf based functions > > fix compilation with gcc 7 > > fix 32-bit build > > fix build with dpdk-17.08-rc2 > > > > app/Makefile | 3 --- > > app/cli-functions.c | 2 +- > > app/lpktgenlib.c | 12 ++---------- > > app/pktgen-cmds.c | 18 +++++++++--------- > > app/pktgen-latency.c | 26 ++++++++++++++------------ > > app/pktgen-log.c | 1 + > > app/pktgen-port-cfg.h | 2 +- > > app/pktgen-stats.c | 47 ++++++++++++++++++++++++++++------------------- > > lib/cli/cli.c | 2 +- > > lib/cli/cli_cmds.c | 6 +++--- > > lib/cli/cli_common.h | 1 + > > lib/cli/cli_map.c | 2 +- > > lib/cli/cli_scrn.c | 5 ++++- > > lib/cli/cli_scrn.h | 1 + > > lib/common/l2p.c | 34 ---------------------------------- > > lib/common/mbuf.h | 3 +++ > > lib/common/port_config.c | 10 +--------- > > 17 files changed, 71 insertions(+), 104 deletions(-) > > Acked by: Keith Wiles > > I did apply these changes and in testing with i40e Pktgen now only sends a few thousand packets then stops sending. I am sure these patches are not the problem, but did you try out Pktgen to see if it worked with 17.08-rc2? Which version of Pktgen did you use? I have not tested these patches except for compilation. I was just trying to enable testing for more people (with different compilers than yours). > I tried with clang and gcc both behave the same. > > I noticed a new message: > i40e_dev_start(): please call hierarchy_commit() before starting the port > i40e_dev_start(): please call hierarchy_commit() before starting the port > i40e_dev_start(): please call hierarchy_commit() before starting the port > i40e_dev_start(): please call hierarchy_commit() before starting the port > > and I tried to add the call in pktgen, but it had no effect. To me the TM API should be defaulted to the original mode and just work unless someone needs to use the TM APIs. The hierarchy_commit routine could not need to be called in the normal case is my guess. Interesting. Please start a new email thread for this bug, cc Wenzhuo and Cristian. Thanks PS: I've noticed that you are the author of all the pktgen commits. Are you using git-am when applying patches from other contributors?