From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 934D6235 for ; Tue, 21 Nov 2017 14:30:49 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 36E4520ACE; Tue, 21 Nov 2017 08:30:49 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:30:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=nrmZnuOcABtAY1vmRE8vNycGot ds2VrMGSP6LNCrXTQ=; b=OlBrjifjrx1jrZiLDvmvOPTQKiA1RMkBWrLwbtYu6x AsZpmSpuHK04hievrVAdjht0/pbh7D/ukpcqBAdA3Im9EOo+xEu4rHjWGU0IAj0I YykZeeexVlk1n5NHkSq7XsblfIKb+G7Bz/+dmabAPwc5TdmstNskCnwUFZTH08az E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=nrmZnu OcABtAY1vmRE8vNycGotds2VrMGSP6LNCrXTQ=; b=HsC9f6hFv/9OJ/9bmLrQjC QDJVHfyfed/8V77WzckTqW72QNDWu+WvAQ22U/FBhMPXvM4MkO2Mm4ZA32xudyrd 1dRdE+/xDWu/PPyRdpo+ssRQnOCvlD6P2FFjNR3e8IBztc9a4EXYxKMQnb/7MtOv y7kDl8UvKd4fCS0vP6d2vEcuZxzx2WMNAL42yFUmXrRaW9h1XMwFV8pWiyRqxRmV LZL9BG9jOEouHbGUl/VDAca827T0vBHKY9MY56s/GF06RmqHBxacgvCqTunXdFD8 AfiB350qpnKZbLzbP5cF+gRBzJDtMiJaP6Z+Q4AnYeWjdsJZVdAoTxPN25TOkIzw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E12367F881; Tue, 21 Nov 2017 08:30:48 -0500 (EST) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula Cc: ferruh.yigit@intel.com, olivier.matz@6wind.com, dev@dpdk.org Date: Tue, 21 Nov 2017 14:30:48 +0100 Message-ID: <5684106.7xpmVRmQS0@xps> In-Reply-To: <20171121111416.yffsbci3cswwpzx5@Pavan-LT> References: <20171116103144.4197-1-pbhagavatula@caviumnetworks.com> <1772478.GecVQuhyhE@xps> <20171121111416.yffsbci3cswwpzx5@Pavan-LT> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:30:49 -0000 21/11/2017 12:14, Pavan Nikhilesh Bhagavatula: > On Tue, Nov 21, 2017 at 11:55:00AM +0100, Thomas Monjalon wrote: > > 20/11/2017 19:40, Ferruh Yigit: > > > And, since you are touching these files :), > > > for better regex support, it may be good to have log types hierarchical, like > > > "lib.mbuf", "lib.mempool", "lib.eal.malloc", as done in member library but with > > > "lib" prefix instead of "librte", if this makes sense and you have time would > > > you mind sending a patch for this as well? > > > > I am not sure about using eal in the library names. > > I think lib.malloc is enough and it would allow to move malloc > > (and other libraries) outside of EAL if needed. > > We already moved PCI and VDEV outside of EAL. More could be moved. > > Does this look good? > > static const struct logtype logtype_strings[] = { > {RTE_LOGTYPE_EAL, "lib.eal"}, > {RTE_LOGTYPE_MALLOC, "lib.malloc"}, > {RTE_LOGTYPE_RING, "lib.ring"}, > {RTE_LOGTYPE_MEMPOOL, "lib.mempool"}, > {RTE_LOGTYPE_TIMER, "lib.timer"}, > {RTE_LOGTYPE_PMD, "pmd"}, > {RTE_LOGTYPE_HASH, "lib.hash"}, > {RTE_LOGTYPE_LPM, "lib.lpm"}, > {RTE_LOGTYPE_KNI, "lib.kni"}, > {RTE_LOGTYPE_ACL, "lib.acl"}, > {RTE_LOGTYPE_POWER, "lib.power"}, > {RTE_LOGTYPE_METER, "lib.meter"}, > {RTE_LOGTYPE_SCHED, "lib.sched"}, > {RTE_LOGTYPE_PORT, "lib.port"}, > {RTE_LOGTYPE_TABLE, "lib.table"}, > {RTE_LOGTYPE_PIPELINE, "lib.pipeline"}, > {RTE_LOGTYPE_MBUF, "lib.mbuf"}, > {RTE_LOGTYPE_CRYPTODEV, "lib.cryptodev"}, > {RTE_LOGTYPE_EFD, "lib.efd"}, > {RTE_LOGTYPE_EVENTDEV, "lib.eventdev"}, > {RTE_LOGTYPE_GSO, "lib.gso"}, > {RTE_LOGTYPE_USER1, "user1"}, > {RTE_LOGTYPE_USER2, "user2"}, > {RTE_LOGTYPE_USER3, "user3"}, > {RTE_LOGTYPE_USER4, "user4"}, > {RTE_LOGTYPE_USER5, "user5"}, > {RTE_LOGTYPE_USER6, "user6"}, > {RTE_LOGTYPE_USER7, "user7"}, > {RTE_LOGTYPE_USER8, "user8"} > }; > > I will be sending out the patch set soon. These are only the legacy static log types. Are you sure you want to change them? They should be removed when using dynamic logging.