From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.mhcomputing.net (master.mhcomputing.net [74.208.228.170]) by dpdk.org (Postfix) with ESMTP id 8BF4358D4 for ; Sun, 3 Jan 2016 23:07:37 +0100 (CET) Received: from mhall-osx-home.local (99-34-229-174.lightspeed.sntcca.sbcglobal.net [99.34.229.174]) by mail.mhcomputing.net (Postfix) with ESMTPSA id 9AAD1B9 for ; Sun, 3 Jan 2016 17:07:36 -0500 (EST) To: dev@dpdk.org References: <674FEFDF-70BD-4C02-947B-10C9F9FC862C@intel.com> From: Matthew Hall Message-ID: <56899BA7.60006@mhcomputing.net> Date: Sun, 3 Jan 2016 14:07:35 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <674FEFDF-70BD-4C02-947B-10C9F9FC862C@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PKTGEN] OK to reindent the pktgen (mix of tabs and spaces, etc.)? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jan 2016 22:07:37 -0000 On 1/3/16 9:09 AM, Wiles, Keith wrote: > Pktgen is setup for tabs for 4 (with replace tabs with spaces), using tab stop of 8 is just wrong IMO :-) > Just started using kdevelop instead of eclipse, so I may have corrupted the style some :-( The problem I found was a number of files had an incompatible combination of the two formats. Personally, I agree tab size 4 w/ spaces instead of tabs is easiest to read and edit. But I could live with any space based system for the most part. I find tab based systems are unpleasant because it is difficult when tabs are used for one thing and spaces for another thing. This annoyance also applies to DPDK and the kernel but it's too late for both of those. > At least it is suppose to be done that way. I will reformat the code (with tabs=4) and have a look at the output. Thanks this will be a big help. > I can run the astyle on the code and look at the output, if it looks OK I will submit it to the repo Sounds great... it is no big hurry on my end but I want to start with a clean slate before I get invested in the code, and start really hitting it hard, and making patches. The formatting command I provided is not perfect, but it was the best I could do with the various popular indenter tools to try to avoid messing up too much of the rest of the good code in the files in the process of fixing the format. You might be able to improve it a bit further w/ some additional experimentation since you are the original maintainer of the code obviously. Or perhaps reformat using tools in Eclipse or KDevelop? I had good luck w/ Eclipse before with special configuration but I only mostly used the Java mode not the C / C++ one which is less good. Matthew.