From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 855B9A04AE; Tue, 8 Feb 2022 14:53:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FF98410FD; Tue, 8 Feb 2022 14:53:02 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id EF045410FC for ; Tue, 8 Feb 2022 14:53:00 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8CFA45C01AE; Tue, 8 Feb 2022 08:53:00 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 08 Feb 2022 08:53:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=BZZ/zQGVaZi9uK qA7yhz5msk0+hpKCbKFNy3GLX1e2o=; b=sELykdP8IXlOUdx86zH0yTmyzN0CRN wFEwebiAfNUZY05kcJmzm3dA/GOXOx9w2Rzn54luj9ygLR1HiVFpzh1sgg1s3r1W SrJ4uRPSvq89JxvBiOwXMqojXWjdGbiTGeiwjvJms9i4mwDWNESrKggSkqH2HmtR lB0Py77VMbeoRBjagpDQk4xe7NYqDWspkRrm5+U8EPGF91TRT+ffc2tV29OsNXiW VHS2gdklHiMD5NhAzHrLTm0Msp1Qk2mFblVNCiKlDtj1XfSkhTAVnCOCcpp1/gBc 3MVqbZubYipf2BwKDQDdS0Caay8wOq/39uiBuzc8bMC7Xmzkeohn32mw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=BZZ/zQGVaZi9uKqA7yhz5msk0+hpKCbKFNy3GLX1e 2o=; b=bjSOa+BYV6vVoQiVTMt9wXtYunJj1QHM9wIb5kmzaaT9IdGI5EzslhmQT E61nsPvbRJ3q+Y8JdReFGkYwqtfdtGB3EJXtRPS3zLQFC7nvCTktm3JovAfMja+/ 7rLYyskQuq75C8oAM1JHz5+hdZrQeCSTwXgmMbw8hYqewP7w25q38/ZKcqYHKL8F q08vtJevSl3hPB4if/elnKX/XTxRLly2yP8RmNU/BhJPEoS1Aixn+w/mCLU5vbKa jC7rDglvXzRcSUSAs8TVyFrwo8m4J67v5UFiiHpT2aRQs8ez/L5LDvXBniB/oUwV MAEGYNH3Ljptu7oAyObKvUNLv1DTA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheejgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdevuedt jeevheevteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Feb 2022 08:52:58 -0500 (EST) From: Thomas Monjalon To: "Min Hu (Connor)" , Morten =?ISO-8859-1?Q?Br=F8rup?= , dev@dpdk.org, Ferruh Yigit Cc: Ray Kinsella , Ajit Khaparde , Andrew Rybchenko Subject: Re: [PATCH] ethdev: introduce ethdev dump API Date: Tue, 08 Feb 2022 14:52:57 +0100 Message-ID: <5691769.MhkbZ0Pkbq@thomas> In-Reply-To: <9900011f-89a2-dc69-523f-2259cb4a7085@intel.com> References: <20220111115437.32855-1-humin29@huawei.com> <8ca8568e-b88c-e758-fc0b-d11b7cb997af@huawei.com> <9900011f-89a2-dc69-523f-2259cb4a7085@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/02/2022 13:59, Ferruh Yigit: > On 2/8/2022 11:14 AM, Min Hu (Connor) wrote: > > =E5=9C=A8 2022/2/8 18:21, Ferruh Yigit =E5=86=99=E9=81=93: > >> What I understand was this API can return any device private informati= on, > >> it is not limited to 'ethdev->data->dev_private', (although most of th= e=20 > > I think this API is limited to 'ethdev->data->dev_private'. > >> data > >> is represented in this struct), like if you want to dump queue state, > >> this is out of 'ethdev->data->dev_private'. > > Queue state can be dumped using API 'rte_eth_tx_queue_info_get'. > >=20 >=20 > Yes it can be. But as far as I can see there is nothing prevents the dump= () > API to provide the same, it is up to PMD. >=20 > If the intention is to limit what can be dump to 'ethdev->data->dev_priva= te', > it is not clear from API documentation/implementation. Why limiting? The dump could even print debug infos which are nowhere else.