From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jianfeng.tan@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id D9AB9567A
 for <dev@dpdk.org>; Tue, 12 Jan 2016 06:46:55 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga102.jf.intel.com with ESMTP; 11 Jan 2016 21:46:54 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,556,1444719600"; d="scan'208";a="879508299"
Received: from shwdeisgchi083.ccr.corp.intel.com (HELO [10.239.67.119])
 ([10.239.67.119])
 by fmsmga001.fm.intel.com with ESMTP; 11 Jan 2016 21:46:53 -0800
To: Tetsuya Mukawa <mukawa@igel.co.jp>, dev@dpdk.org, huawei.xie@intel.com
References: <1446748276-132087-1-git-send-email-jianfeng.tan@intel.com>
 <1452426182-86851-1-git-send-email-jianfeng.tan@intel.com>
 <569490D9.10803@igel.co.jp>
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Message-ID: <5694934B.5070900@intel.com>
Date: Tue, 12 Jan 2016 13:46:51 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <569490D9.10803@igel.co.jp>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: nakajima.yoshihiro@lab.ntt.co.jp, mst@redhat.com,
 ann.zhuangyanying@huawei.com
Subject: Re: [dpdk-dev] [PATCH 0/4] virtio support for container
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jan 2016 05:46:56 -0000


Hi Tetsuya,
  

> Hi Jianfeng and Xie,
>
> I guess my implementation and yours have a lot of common code, so I will
> try to rebase my patch on yours.

We also think so. And before you rebase your code, I think we can rely 
on Yuanhan's
struct virtio_pci_ops to make the code structure brief and clear, as 
discussed in your
patch's thread, i.e., we both rebase our code according to Yuanhan's 
code. Is that OK?


>
> BTW, one thing I need to change your memory allocation way is that
> mmaped address should be under 44bit(32 + PAGE_SHIFT) to work with my patch.
> This is because VIRTIO_PCI_QUEUE_PFN register only accepts such address.
> (I may need to add one more EAL parameter like "--mmap-under <address>")

It makes sense.

Thanks,
Jianfeng

>
> Thanks,
> Tetsuya