DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz@6wind.com>
To: Declan Doherty <declan.doherty@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	 Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [RFC] cryptodev: Change burst APIs to crypto operation oriented
Date: Mon, 18 Jan 2016 15:31:34 +0100	[thread overview]
Message-ID: <569CF746.5060605@6wind.com> (raw)
In-Reply-To: <569541C2.60302@intel.com>

Hi Declan,

On 01/12/2016 07:11 PM, Declan Doherty wrote:
> In this rfc I'm looking to get some feedback on a proposal to change the
> cryptodev burst API from the current implementation of accepting burst
> of rte_mbuf's to a burst API based on rte_crypto_op's.
> 
> -static inline uint16_t
> -rte_cryptodev_dequeue_burst(uint8_t dev_id, uint16_t qp_id,
> -               struct rte_mbuf **pkts, uint16_t nb_pkts)
> +static inline uint16_t
> +rte_cryptodev_dequeue_op_burst(uint8_t dev_id, uint16_t qp_id,
> +               struct rte_crypto_op **ops, uint16_t nb_ops)
> 
> 
> -static inline uint16_t
> -rte_cryptodev_dequeue_burst(uint8_t dev_id, uint16_t qp_id,
> -               struct rte_mbuf **pkts, uint16_t nb_pkts)
> + static inline uint16_t
> +rte_cryptodev_dequeue_op_burst(uint8_t dev_id, uint16_t qp_id,
> +               struct rte_crypto_op **ops, uint16_t nb_ops)
> 
> 
> [...]
> 
> Regarding the rte_mbuf_offload library I think that it should be removed
> and that we can look adding a more general solution for managing
> external metadata to the rte_mbuf library when that functionality is
> required.

This looks fine to me.

Thanks,
Olivier

      reply	other threads:[~2016-01-18 14:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12 18:11 Declan Doherty
2016-01-18 14:31 ` Olivier MATZ [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569CF746.5060605@6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).