DPDK patches and discussions
 help / color / mirror / Atom feed
From: Matthew Hall <mhall@mhcomputing.net>
To: dev@dpdk.org
Subject: [dpdk-dev] igb: correctly setting default value TX_WTHRESH (due to performance warning during PMD init)
Date: Tue, 19 Jan 2016 22:43:54 -0800	[thread overview]
Message-ID: <569F2CAA.7080708@mhcomputing.net> (raw)

I get this error when running DPDK with the IGB driver in pktgen-dpdk 
and other code:

PMD: WARNING: eth_igb_tx_queue_setup(): To improve 1G driver 
performance, consider setting the TX WTHRESH value to 4, 8, or 16.

Internally, the code is checking "if (tx_conf->tx_thresh.wthresh == 0)".

But, I am confused now because a while ago I thought we made a bunch of 
DPDK usability changes to get rid of this headache. I remember reading / 
learning that if you set zero for most rx_conf and tx_conf parameters, 
the PMD is supposed to auto-select sane default values.

Given that, why are you forced to set TX_WTHRESH by hand for igb?
What sane default value one should pick for this setting?

Could we do something better to auto-select this like we did for most 
rx_conf / tx_conf settings previously? Or did I miss something about the 
usability changes or do something wrong?

Sincerely,
Matthew Hall.

                 reply	other threads:[~2016-01-20  6:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569F2CAA.7080708@mhcomputing.net \
    --to=mhall@mhcomputing.net \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).