From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mhall@mhcomputing.net>
Received: from mail.mhcomputing.net (master.mhcomputing.net [74.208.228.170])
 by dpdk.org (Postfix) with ESMTP id 0403CF72
 for <dev@dpdk.org>; Wed, 20 Jan 2016 07:43:16 +0100 (CET)
Received: from mhall-osx-home.local
 (99-34-229-174.lightspeed.sntcca.sbcglobal.net [99.34.229.174])
 by mail.mhcomputing.net (Postfix) with ESMTPSA id C6E40FC
 for <dev@dpdk.org>; Wed, 20 Jan 2016 01:43:13 -0500 (EST)
To: dev@dpdk.org
From: Matthew Hall <mhall@mhcomputing.net>
Message-ID: <569F2CAA.7080708@mhcomputing.net>
Date: Tue, 19 Jan 2016 22:43:54 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0)
 Gecko/20100101 Thunderbird/38.5.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [dpdk-dev] igb: correctly setting default value TX_WTHRESH (due to
 performance warning during PMD init)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jan 2016 06:43:16 -0000

I get this error when running DPDK with the IGB driver in pktgen-dpdk 
and other code:

PMD: WARNING: eth_igb_tx_queue_setup(): To improve 1G driver 
performance, consider setting the TX WTHRESH value to 4, 8, or 16.

Internally, the code is checking "if (tx_conf->tx_thresh.wthresh == 0)".

But, I am confused now because a while ago I thought we made a bunch of 
DPDK usability changes to get rid of this headache. I remember reading / 
learning that if you set zero for most rx_conf and tx_conf parameters, 
the PMD is supposed to auto-select sane default values.

Given that, why are you forced to set TX_WTHRESH by hand for igb?
What sane default value one should pick for this setting?

Could we do something better to auto-select this like we did for most 
rx_conf / tx_conf settings previously? Or did I miss something about the 
usability changes or do something wrong?

Sincerely,
Matthew Hall.