From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 437A2A04C7; Tue, 15 Sep 2020 17:57:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C4521C0C6; Tue, 15 Sep 2020 17:57:55 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AE6491C0C2 for ; Tue, 15 Sep 2020 17:57:53 +0200 (CEST) IronPort-SDR: nK2UNeD/L6+9RCCumTMzhXOhqUY1dUDDhS8xaxmSwvt67fvenyqszj96nldgzfjE7b0yChcUGN HPJCuoUUiuAQ== X-IronPort-AV: E=McAfee;i="6000,8403,9745"; a="159338991" X-IronPort-AV: E=Sophos;i="5.76,430,1592895600"; d="scan'208";a="159338991" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 08:57:50 -0700 IronPort-SDR: DLGGKlzlZ7OJsOpwioxsj33tUOV+diqmjMr6bo3mDZPGB/t1JEE+krUZeu1E0Y6RjemETwuKKD 8wzDSsHzk/6A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,430,1592895600"; d="scan'208";a="335711076" Received: from irsmsx606.ger.corp.intel.com ([163.33.146.139]) by orsmga008.jf.intel.com with ESMTP; 15 Sep 2020 08:57:49 -0700 Received: from irsmsx601.ger.corp.intel.com (163.33.146.7) by IRSMSX606.ger.corp.intel.com (163.33.146.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 15 Sep 2020 16:57:48 +0100 Received: from irsmsx601.ger.corp.intel.com ([163.33.146.7]) by irsmsx601.ger.corp.intel.com ([163.33.146.7]) with mapi id 15.01.1713.004; Tue, 15 Sep 2020 16:57:48 +0100 From: "Richardson, Bruce" To: Thomas Monjalon , David Marchand , "Chautru, Nicolas" , "Power, Ciara" CC: dev Thread-Topic: [PATCH v4 00/31] remove make support in DPDK Thread-Index: AQHWhWNNKtYTVh20SkWEyWscaNKwQqleZdiA///8+ACAC1NqAIAAEmIAgAAJ6oCAABQ64A== Date: Tue, 15 Sep 2020 15:57:48 +0000 Message-ID: <569c544c659c48dcb5a75af2581a1a8d@intel.com> References: <20200903152717.42095-1-ciara.power@intel.com> <3216590.6Dkn3NIytC@thomas> In-Reply-To: <3216590.6Dkn3NIytC@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [163.33.253.164] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 00/31] remove make support in DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, September 15, 2020 4:44 PM > To: David Marchand ; Chautru, Nicolas > ; Power, Ciara > Cc: Richardson, Bruce ; dev > Subject: Re: [PATCH v4 00/31] remove make support in DPDK >=20 > 15/09/2020 17:08, Power, Ciara: > > Hi David, > > > > > > >-----Original Message----- > > >From: David Marchand > > >Sent: Tuesday 15 September 2020 15:03 > > >To: Thomas Monjalon ; Chautru, Nicolas > > > > > >Cc: Richardson, Bruce ; dev > > >; Power, Ciara > > >Subject: Re: [PATCH v4 00/31] remove make support in DPDK > > > > > >On Tue, Sep 8, 2020 at 11:05 AM Thomas Monjalon > > >wrote: > > >> > > >> 08/09/2020 10:16, Bruce Richardson: > > >> > On Tue, Sep 08, 2020 at 12:06:40AM +0200, Thomas Monjalon wrote: > > >> > > The first 13 commits of this series are pushed to the main > > >> > > branch, making the make-based build an old story. > > >> > > > > >> > > The last 18 commits (devtools, app and doc) are pending for > > >> > > more reviews, especially because the doc rework is still in > progress. > > >> > > This is a big change which requires to be split but must be > > >> > > completed soon. > > >> > > *All*, please make the documentation update your highest > priority. > > >> > > I will be reluctant to merge some driver changes if the related > > >> > > doc is not updated. > > >> > > > > >> > Thanks for the apply of the code patches, I think it will make > > >> > all our subsequent patch submissions a bit cleaner. > > >> > > > >> > In terms of docs, I believe the Linux and FreeBSD GSG guides to > > >> > be ready for merge, or if not 100% they are at least good enough > > >> > IMHO to be applied now and have some minor tweaks in subsequent > > >> > patches later. While I'm sure the Linux GSG could do with more > > >> > major rework, that should be separate from the doc updates in this > patch. > > >> > > >> Of course I am not expecting any major rework in these patches, but > > >> I don't want to apply clean-up half done, which can drop some > > >> relevant informations or introduce mistakes. > > >> > > >> I will review the Linux and FreeBSD user guides first, as you > suggest. > > > > > >I could not find a patch in patchwork for > > >app/test-bbdev/test-bbdev.py which still references RTE_SDK and > RTE_TARGET. > > > > > > > > >-- > > >David Marchand > > > > > > Changes to test-bbdev.py were made in patch 15: > https://patchwork.dpdk.org/patch/76796/ to remove the references to > RTE_SDK and RTE_TARGET. >=20 > I did not merge this patch because it is hardcoding "build" as a > directory. > I'm sure we can do better. >=20 We probably can, but is it really worth holding up the patch over something= as trivial as that? It is really likely to cause people issues?