From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 4C7F0377E for ; Mon, 8 Feb 2016 07:59:43 +0100 (CET) Received: by mail-pa0-f51.google.com with SMTP id cy9so69293514pac.0 for ; Sun, 07 Feb 2016 22:59:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=qx9f55D9lIW6qKX3FyaVkoHxMMT2hIWhvvFxGwBFl5k=; b=0ChhTPKolD2k/8U5lOjKBZ99W8Vt7m50QWaBoWTm3Nh5qIWJ/M4n+Q3kvpC2ptOWDe 6FkeG9e88DrAyGjaWaOTTkLBV8ntTflxOl6V/GKK2lalEMr/uGvSVjBjUden3bimiaCB 61WqxeomvXgOx6atvYoHOs8e05nAf6GXpxFrJElkM3SxQVe7VmfM/iQs10CiMDj8tADV Kmpw/yYGo4CjzVU3ZL8u577Zo0uag3fazNm9BzBy4fxnLyFKxjZ+uRMjKtcwyOrvJcE8 GXrHPqQsjNfYZbf45BFMp/+LQLJYcgJmoG2hXuReXvbT8TV5C561fXiFpjzF6B78H4th Vh3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=qx9f55D9lIW6qKX3FyaVkoHxMMT2hIWhvvFxGwBFl5k=; b=CZeKJ2frMpd8rUpvxzlp1NwIS0NQSZbnbNx1602vRvOAh/jt/i7zdsYdcStViYbwcq LyiunBWGaWM7LcWvrPi7ZWVCAtSs5YedfXKokxDc9k7bop1HMahde790+vfTVbrOQ8CD JrMEq9l1L6Wl4UmBotqpKYm3K2L8hIyicVaLBF4M/v5cg+AUdbuDXUYmNc69TLpwh19N E2W2xJ76YldiUtYzOfHeyx/5WMiHsX4cEjt1PVldGVgj/rM4tzAxh02a23FHABV2jEiG JnWhN1NcX7YB9e1+OESBnC7bKqL6tGqxosL2WxGLLih0XYbZ2QWkO+XP9teqB/wHuV6b AVdQ== X-Gm-Message-State: AG10YORIBokdK7PBkJUzxNSnzYUK1l/OOxOrBrmRR134igsg1oVMg62Yg+kl6FjtmH6jTQ== X-Received: by 10.66.100.228 with SMTP id fb4mr39652077pab.84.1454914782705; Sun, 07 Feb 2016 22:59:42 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id w89sm14291302pfi.13.2016.02.07.22.59.39 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 07 Feb 2016 22:59:41 -0800 (PST) To: Jianfeng Tan , dev@dpdk.org References: <1446748276-132087-1-git-send-email-jianfeng.tan@intel.com> <1454671228-33284-1-git-send-email-jianfeng.tan@intel.com> <1454671228-33284-4-git-send-email-jianfeng.tan@intel.com> From: Tetsuya Mukawa Message-ID: <56B83CDA.7020106@igel.co.jp> Date: Mon, 8 Feb 2016 15:59:38 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454671228-33284-4-git-send-email-jianfeng.tan@intel.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Cc: nakajima.yoshihiro@lab.ntt.co.jp, mst@redhat.com, ann.zhuangyanying@huawei.com Subject: Re: [dpdk-dev] [PATCH v2 3/5] virtio/vdev: add embeded device emulation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2016 06:59:43 -0000 On 2016/02/05 20:20, Jianfeng Tan wrote: > To implement virtio vdev, we need way to interract with vhost backend. > And more importantly, needs way to emulate a device into DPDK. So this > patch acts as embedded device emulation. > > Depends on the type of vhost file: vhost-user is used if the given > path points to a unix socket; vhost-net is used if the given path > points to a char device. > > Signed-off-by: Huawei Xie > Signed-off-by: Jianfeng Tan > --- > > +void > +virtio_vdev_init(struct rte_eth_dev_data *data, char *path, > + int nb_rx, int nb_tx, int nb_cq __attribute__ ((unused)), > + int queue_num, char *mac, char *ifname) > +{ > + int i, r; > + struct stat s; > + uint32_t tmp[ETHER_ADDR_LEN]; > + struct virtio_hw *hw = data->dev_private; > + > + hw->vtpci_ops = &vdev_ops; > + hw->io_base = 0; > + hw->use_msix = 0; > + hw->modern = 0; > + > + hw->data = data; > + hw->path = strdup(path); > + hw->max_rx_queues = nb_rx; > + hw->max_tx_queues = nb_tx; > + hw->queue_num = queue_num; > + hw->mac_specified = 0; > + if (mac) { > + r = sscanf(mac, "%x:%x:%x:%x:%x:%x", &tmp[0], > + &tmp[1], &tmp[2], &tmp[3], &tmp[4], &tmp[5]); > + if (r == ETHER_ADDR_LEN) { > + for (i = 0; i < ETHER_ADDR_LEN; ++i) > + hw->mac_addr[i] = (uint8_t)tmp[i]; > + hw->mac_specified = 1; > + } else > + PMD_DRV_LOG(WARN, "wrong format of mac: %s", mac); It seems you cannot use 'WARN' here. Thanks, Tetsuya