From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vincent.jardin@6wind.com>
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id 8E10C568A
 for <dev@dpdk.org>; Thu, 11 Feb 2016 07:45:41 +0100 (CET)
Received: by mail-wm0-f41.google.com with SMTP id g62so55605741wme.0
 for <dev@dpdk.org>; Wed, 10 Feb 2016 22:45:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=message-id:date:from:organization:user-agent:mime-version:to:cc
 :subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=j+lePwwCNExkHTFggp8ylY7sZjSs6X6RUb57xcPwOTM=;
 b=KAmFxSDTUi3BE48Uhw3+UpxTzy1X4bz2GJn7wZnR9KiJtKn98hJrjfXzJIStjh+K+K
 MlsHfZ91pEIC9JFdgU1IaUtH56bjwekAlezPF7aBhyy7I+BhhSktQDf4mzAaeq4gacdl
 nYQ/fxAJAuN/Y7rIkIhK6+0RpRlZvCYZABWKcNOukcXzyCUw30wFDnd8ZQrd+nLCzKKA
 Wa6+hG1Lh4h0FRbNx3P+OFEsua3UdA6d2b3sBOttbofjP2n5Pmpev68i+0+xJo/KdqcE
 KB349yWADQopilWy1tyddjmXpuiwVfY7QUfkExqaCG/KSVT+Di3TxtVocNDLHONxMHvj
 OkFw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:organization:user-agent
 :mime-version:to:cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=j+lePwwCNExkHTFggp8ylY7sZjSs6X6RUb57xcPwOTM=;
 b=Cl+YvsUvmeCzUywH5Rf6Jh84K17Dx8P5VAQvs3vqKOUbyE4nKXXgjj20ILjlJPmIUg
 Hm6kQ5VOkPSvoI8pIH8qpjcYOSpUtqTQsGG8nzH7llVo4UXogs2tEc2y24tD8YPJ0Axz
 Al0J1dTMpAw53rGtWg939kR6m5mcl/pUbRQapZdppmQOcxc5uMx8KjwpufqgaDH0tqnR
 hLdKxVMycCMOpequmm6SzGkDSX5iWjEwJ5HV29R1JlFGd0AymR03+WZ36oXL6UdwM1Hz
 T9NLAqAOaWy2jwRclIccZFYn90kvyaufQT6uTdv2Iz0UuiXscLAaSl6+q0H8QnEKRJpY
 2vRg==
X-Gm-Message-State: AG10YOTRkhuI1Au62v5G9v2R+FF5ytdfPURVicgdPIm7VBBSR+hx4ZKx39VlV6yifrqn0Cu3
X-Received: by 10.194.220.230 with SMTP id pz6mr14199203wjc.39.1455173141355; 
 Wed, 10 Feb 2016 22:45:41 -0800 (PST)
Received: from saturne.dev.6wind.com ([195.77.232.109])
 by smtp.gmail.com with ESMTPSA id b5sm24804087wmh.15.2016.02.10.22.45.39
 (version=TLSv1/SSLv3 cipher=OTHER);
 Wed, 10 Feb 2016 22:45:40 -0800 (PST)
Message-ID: <56BC2E0F.4020508@6wind.com>
Date: Thu, 11 Feb 2016 07:45:35 +0100
From: Vincent JARDIN <vincent.jardin@6wind.com>
Organization: www.6wind.com
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Stephen Hemminger <stephen@networkplumber.org>
References: <1455147934-15060-1-git-send-email-vincent.jardin@6wind.com>
 <20160210171236.77aa24dc@xeon-e3>
In-Reply-To: <20160210171236.77aa24dc@xeon-e3>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] virtio: prettify log messages
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Feb 2016 06:45:41 -0000

On 11/02/2016 02:12, Stephen Hemminger wrote:
> I would rather the macros were aligned with ixgbe which always
> adds newline for all the PMD_XXX_LOG() macros. And then remove
> all extra newlines in virtio code.
you right