From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A3E47E07 for ; Thu, 11 Feb 2016 17:56:08 +0100 (CET) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id D612F3407EC; Thu, 11 Feb 2016 16:56:07 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-6-26.ams2.redhat.com [10.36.6.26]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1BGu6LA019574; Thu, 11 Feb 2016 11:56:07 -0500 To: krytarowski@caviumnetworks.com, dev@dpdk.org References: <1454423239-16382-1-git-send-email-krytarowski@caviumnetworks.com> <1454423239-16382-2-git-send-email-krytarowski@caviumnetworks.com> From: Panu Matilainen Message-ID: <56BCBD26.9050802@redhat.com> Date: Thu, 11 Feb 2016 18:56:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1454423239-16382-2-git-send-email-krytarowski@caviumnetworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: Export rte_eth_dev_create_unique_device_name() to public API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2016 16:56:08 -0000 On 02/02/2016 04:27 PM, krytarowski@caviumnetworks.com wrote: > From: Kamil Rytarowski > > Once pci_drv.devinit is overloaded, it's a function used in the original > rte_eth_dev_init(), still reusable in altered versions. > > Signed-off-by: Kamil Rytarowski > --- > lib/librte_ether/rte_ethdev.c | 2 +- > lib/librte_ether/rte_ethdev.h | 18 ++++++++++++++++++ > 2 files changed, 19 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index ac4aeab..7f5e741 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -214,7 +214,7 @@ rte_eth_dev_allocate(const char *name, enum rte_eth_dev_type type) > return eth_dev; > } > > -static int > +int > rte_eth_dev_create_unique_device_name(char *name, size_t size, > struct rte_pci_device *pci_dev) > { > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 8710dd7..b19db9d 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -3880,6 +3880,24 @@ rte_eth_dma_zone_reserve(const struct rte_eth_dev *eth_dev, const char *name, > uint16_t queue_id, size_t size, > unsigned align, int socket_id); > > +/** > + * Create unique device name > + * > + * @param name > + * The port identifier of the Ethernet device. > + * @param size > + * Maximum string length of the generated name > + * @param pci_dev > + * PCI device pointer > + * > + * @return > + * - 0: Success. > + * - <0: Error during generatin > + * - -EINVAL: Invalid input parameters. > + */ > +int rte_eth_dev_create_unique_device_name(char *name, size_t size, > + struct rte_pci_device *pci_dev); > + > #ifdef __cplusplus > } > #endif > To really export it, you'll need to add it to rte_ether_version.map as well. - Panu -