From: Fernando Seiti Furusato <ferseiti@linux.vnet.ibm.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] build: set CFLAGS for ppc64el build
Date: Fri, 12 Feb 2016 17:18:45 -0200 [thread overview]
Message-ID: <56BE3015.7090804@linux.vnet.ibm.com> (raw)
In-Reply-To: <2231851.1TVA0CgCFh@xps13>
Hello Thomas.
Thanks for your quick response.
On 02/12/2016 03:37 PM, Thomas Monjalon wrote:
> 2016-02-12 12:05, Fernando Seiti Furusato:
>> Add a proper ifeq statement to set the mcpu as needed for ppc64el, as
>> the only one originally set is not valid for ppc architectures.
>
> What is the benefit of using the default machine config, compared to
> the power8 one?
>
> Don't you think the default machine should be renamed core2?
I think it would be better indeed. Thanks for pointing that out.
>
> [...]
>> +ifeq (ppc64le,$(shell uname -m))
>> + MACHINE_CFLAGS += -mcpu=power8
>
> Why this flag is not set in mk/machine/power8/rte.vars.mk ?
>
This and what observed above would make a better patch.
Let me try those.
Thanks!
--
Fernando Seiti Furusato
IBM Linux Technology Center
next prev parent reply other threads:[~2016-02-12 19:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 17:05 Fernando Seiti Furusato
2016-02-12 17:37 ` Thomas Monjalon
2016-02-12 19:18 ` Fernando Seiti Furusato [this message]
2016-02-16 18:04 ` Fernando Seiti Furusato
2016-02-16 18:09 ` Thomas Monjalon
2016-02-16 19:07 ` Fernando Seiti Furusato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BE3015.7090804@linux.vnet.ibm.com \
--to=ferseiti@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).