From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.griffin@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id EDFC92C7A
 for <dev@dpdk.org>; Wed, 17 Feb 2016 14:29:17 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga103.jf.intel.com with ESMTP; 17 Feb 2016 05:29:17 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,460,1449561600"; d="scan'208";a="917004325"
Received: from sie-lab-212-151.ir.intel.com (HELO [10.237.212.151])
 ([10.237.212.151])
 by fmsmga002.fm.intel.com with ESMTP; 17 Feb 2016 05:29:15 -0800
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
References: <1455615876-29879-1-git-send-email-john.griffin@intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D8973C8A63DE@IRSMSX108.ger.corp.intel.com>
From: John Griffin <john.griffin@intel.com>
Message-ID: <56C475AA.2040506@intel.com>
Date: Wed, 17 Feb 2016 13:29:14 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C8A63DE@IRSMSX108.ger.corp.intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] qat pmd:Fixing build issue on 32-bit systems
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Feb 2016 13:29:18 -0000

Hi Pablo,
Sure - will resubmit a v2 with those modifications.

Thanks,
John.

On 16/02/16 15:52, De Lara Guarch, Pablo wrote:
> Hi John,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Griffin
>> Sent: Tuesday, February 16, 2016 9:45 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] qat pmd:Fixing build issue on 32-bit systems
>>
>> Fixing build issue on 32-bit systems.
>> Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")
>>
>> Signed-off-by: John Griffin <john.griffin@intel.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Could you include the error that you are fixing on this patch?
>
> For example:
>
> drivers/crypto/qat/qat_crypto.c:345:13:
> error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>
> Also, as a general rule, patch titles start with lowercase and do not include the name "issue" if we use "fix".
> e.g. (qat: fix build on 32-bit systems).
>
> Apart from this, patch looks OK to me, so you can leave the acknowledgment in the v2.
>
> Thanks!
> Pablo
>