From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-000f0801.pphosted.com (mx0b-000f0801.pphosted.com [67.231.152.113]) by dpdk.org (Postfix) with ESMTP id E8CF3137C for ; Thu, 18 Feb 2016 13:20:19 +0100 (CET) Received: from pps.filterd (m0000700.ppops.net [127.0.0.1]) by mx0b-000f0801.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id u1ICGP3j006788; Thu, 18 Feb 2016 04:20:17 -0800 Received: from brmwp-exmb11.corp.brocade.com ([208.47.132.227]) by mx0b-000f0801.pphosted.com with ESMTP id 214cgydhx6-1 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 18 Feb 2016 04:20:17 -0800 Received: from EMEAWP-EXMB12.corp.brocade.com (172.29.11.86) by BRMWP-EXMB11.corp.brocade.com (172.16.59.77) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Thu, 18 Feb 2016 05:20:16 -0700 Received: from [172.29.197.21] (172.29.197.21) by EMEAWP-EXMB12.corp.brocade.com (172.29.11.86) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Thu, 18 Feb 2016 13:20:12 +0100 To: Bruce Richardson References: <1454084293-5722-1-git-send-email-patkins@brocade.com> <1600067.TyQ2MXbqf2@xps13> <56AB97BE.9030106@brocade.com> <20160217172336.GC11736@bricha3-MOBL3> From: Paul Atkins Message-ID: <56C5B6EE.9030805@brocade.com> Date: Thu, 18 Feb 2016 12:19:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160217172336.GC11736@bricha3-MOBL3> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [172.29.197.21] X-ClientProxiedBy: hq1wp-excas14.corp.brocade.com (10.70.38.103) To EMEAWP-EXMB12.corp.brocade.com (172.29.11.86) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-02-18_05:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1602180185 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/3] null driver improvements for testability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2016 12:20:20 -0000 On 17/02/16 17:23, Bruce Richardson wrote: > On Fri, Jan 29, 2016 at 04:47:58PM +0000, Paul Atkins wrote: >> Hi Thomas, >> >> On 29/01/16 16:31, Thomas Monjalon wrote: >>> Hi Paul, >>> >>> 2016-01-29 16:18, Paul Atkins: >>>> This patchset adds functionality to the null driver help when testing >>>> a dataplane that uses dpdk. The idea is that the the dataplane can >>>> have multiple null interfaces attached, and each of theses can be >>>> assigned a mac address. Packets can then be injected into the null >>>> drivers by adding them to a ring, giving the application complete >>>> control of the packets that arrive. Packets that are sent by a null >>>> driver can be stored on a ring, where the application can pick them up >>>> and verify it is what was expected. To allow the application to know >>>> when packets have been pulled of the rx ring, counters of the number of >>>> times an rx poll has been made are kept, and these can be retrieved via >>>> the existing APIs. >>> I have not read your code, just read this description. >>> It sounds like being a ring PMD. Have you already checked it? >>> https://urldefense.proofpoint.com/v2/url?u=http-3A__dpdk.org_browse_dpdk_tree_drivers_net_ring_rte-5Feth-5Fring.c&d=CwICAg&c=IL_XqQWOjubgfqINi2jTzg&r=45ezphVDEm8OnEpH-fLWdXvR3RneLhhNZRDLQRgR6LY&m=wJLO24XFe_B0nZve6mkvocCt7fQWo3PULCTWxrC8rZk&s=bIWycJrY-PYgzkQsBeRfkl8JCHFcxRAHhHDrqRSzHYs&e= >> I hadn't seen the ring PMD. I will have a look at it and see if I can make >> it do what i need. >> >> thanks, >> Paul > Hi Paul, > > any update on this. Your patches are still showing as pending in patchwork, but > if ring pmd is more what need, we can set these patches aside as unneeded, and > remove them from the patchwork merge backlog. Hi Bruce, Sorry for the delay. The patchset adds 3 things: assigning a mac addr to the null pmd, adding the rings to the null pmd and adding xstats for how many times the null pmd has been polled. I could move to using the ring pmd, but I would still need the other 2 parts (mac addr and stats). It seems like the ring pmd shouldn't really have these two extra things added, but i could do that if it that is preferred over what is in the current patchset. thanks, Paul > > thanks, > /Bruce