From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8887EC358 for ; Thu, 18 Feb 2016 14:39:28 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id BF7B08E51D; Thu, 18 Feb 2016 13:39:27 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-5-209.ams2.redhat.com [10.36.5.209]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1IDdQI2024297; Thu, 18 Feb 2016 08:39:27 -0500 To: Yuanhan Liu References: <20160218132549.GN21426@yliu-dev.sh.intel.com> From: Panu Matilainen Message-ID: <56C5C98E.7010205@redhat.com> Date: Thu, 18 Feb 2016 15:39:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160218132549.GN21426@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2016 13:39:28 -0000 On 02/18/2016 03:25 PM, Yuanhan Liu wrote: > On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote: >> Commit d0cf91303d73 added dependency on librte_net headers to vhost >> but did not add this to the Makefile, which makes builds >> non-deterministic. Curiously it is non-parallel build that is >> consistently broken by this missing dependency, usually it's the other >> way around, but trying to build without -j(n) fails with: > > Yeah, I have confirmed it; I was wondering why I didn't meet such build > error. > >> >> dpdk/lib/librte_vhost/vhost_rxtx.c:41:20: >> fatal error: rte_ip.h: No such file or directory >> >> Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities") >> Signed-off-by: Panu Matilainen > > Acked-by: Yuanhan Liu > > Thanks. > > BTW, please cc me for virtio/vhost patches next time, otherwise, it's > easily got overlooked: too many emails. Hmm, I thought I did. Looking more carefully now, I mixed up the patch author (who was CC'd) with you: commit d0cf91303d731997945420832ee245b21f292e19 Author: Jijiang Liu I hate it when people call me Paul (commonly happens) just because it vaguely resembles my name, so I really should do better than this. Apologies, I'll pay closer attention in the future. - Panu -