From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6C68B2C29 for ; Fri, 26 Feb 2016 09:36:13 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 26 Feb 2016 00:36:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="911701058" Received: from shwdeisgchi083.ccr.corp.intel.com (HELO [10.239.67.193]) ([10.239.67.193]) by fmsmga001.fm.intel.com with ESMTP; 26 Feb 2016 00:36:11 -0800 To: dev@dpdk.org, helin.zhang@intel.com, konstantin.ananyev@intel.com, nelio.laranjeiro@6wind.com, rahul.lakkireddy@chelsio.com References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com> <1456445371-147264-1-git-send-email-jianfeng.tan@intel.com> <1456445371-147264-10-git-send-email-jianfeng.tan@intel.com> <20160226082622.GB27079@6wind.com> From: "Tan, Jianfeng" Message-ID: <56D00E7A.7050905@intel.com> Date: Fri, 26 Feb 2016 16:36:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160226082622.GB27079@6wind.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 09/12] pmd/mlx5: add dev_ptype_info_get implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2016 08:36:13 -0000 Hi, On 2/26/2016 4:26 PM, Adrien Mazarguil wrote: > Hi Jianfeng, > > On Fri, Feb 26, 2016 at 08:09:28AM +0800, Jianfeng Tan wrote: >> Signed-off-by: Jianfeng Tan >> --- >> drivers/net/mlx4/mlx4.c | 2 +- >> drivers/net/mlx5/mlx5.c | 1 + >> drivers/net/mlx5/mlx5.h | 1 + >> drivers/net/mlx5/mlx5_ethdev.c | 20 ++++++++++++++++++++ >> drivers/net/mlx5/mlx5_rxtx.c | 2 ++ >> 5 files changed, 25 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c >> index 85fdebf..58f4e1a 100644 >> --- a/drivers/net/mlx4/mlx4.c >> +++ b/drivers/net/mlx4/mlx4.c >> @@ -4269,7 +4269,7 @@ mlx4_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) >> priv_unlock(priv); >> } >> >> -static uint32_t * >> +static const uint32_t * >> mlx4_dev_ptype_info_get(struct rte_eth_dev *dev) >> { >> static const uint32_t ptypes[] = { > I'm probably nitpicking here but this change should be merged in the mlx4 > patch. Otherwise both mlx4 and mlx5 patches look fine to me. > Oops, nice catch. It's should be in mlx4 commit. I'll fix it. Thanks, Jianfeng