From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D3C542A5E for ; Mon, 29 Feb 2016 12:04:47 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 29 Feb 2016 03:04:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,520,1449561600"; d="scan'208";a="913436335" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.220.123]) ([10.237.220.123]) by fmsmga001.fm.intel.com with ESMTP; 29 Feb 2016 03:04:46 -0800 To: Olivier MATZ , dev@dpdk.org References: <1453829155-1366-1-git-send-email-david.hunt@intel.com> <1455634095-4183-1-git-send-email-david.hunt@intel.com> <1455634095-4183-3-git-send-email-david.hunt@intel.com> <56C71919.50506@6wind.com> From: "Hunt, David" Message-ID: <56D425CC.4020709@intel.com> Date: Mon, 29 Feb 2016 11:04:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56C71919.50506@6wind.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/6] mempool: add stack (lifo) based external mempool handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Feb 2016 11:04:48 -0000 On 2/19/2016 1:31 PM, Olivier MATZ wrote: > Hi David, > > On 02/16/2016 03:48 PM, David Hunt wrote: >> adds a simple stack based mempool handler >> >> Signed-off-by: David Hunt >> --- >> lib/librte_mempool/Makefile | 2 +- >> lib/librte_mempool/rte_mempool.c | 4 +- >> lib/librte_mempool/rte_mempool.h | 1 + >> lib/librte_mempool/rte_mempool_stack.c | 164 +++++++++++++++++++++++++++++++++ >> 4 files changed, 169 insertions(+), 2 deletions(-) >> create mode 100644 lib/librte_mempool/rte_mempool_stack.c >> > I don't get what is the purpose of this handler. Is it an example > or is it something that could be useful for dpdk applications? > > If it's an example, we should find a way to put the code outside > the librte_mempool library, maybe in the test program. I see there > is also a "custom handler". Do we really need to have both? They are both example handlers. I agree that we could reduce down to one, and since the 'custom' handler has autotests, I would suggest we keep that one. The next question is where it should live. I agree that it's not ideal to have example code living in the same directory as the mempool library, but they are an integral part of the library itself. How about creating a handlers sub-directory? We could then keep all additional and sample handlers in there, away from the built-in handlers. Also, seeing as the handler code is intended to be part of the library, I think moving it out to the examples directory may confuse matters further. Regards, David.