From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 23A39685C for ; Mon, 29 Feb 2016 12:11:24 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 29 Feb 2016 03:11:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,520,1449561600"; d="scan'208";a="923336417" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.220.123]) ([10.237.220.123]) by orsmga002.jf.intel.com with ESMTP; 29 Feb 2016 03:11:23 -0800 To: Olivier MATZ , dev@dpdk.org References: <1453829155-1366-1-git-send-email-david.hunt@intel.com> <1455634095-4183-1-git-send-email-david.hunt@intel.com> <1455634095-4183-2-git-send-email-david.hunt@intel.com> <56C71913.10901@6wind.com> From: "Hunt, David" Message-ID: <56D4275A.4070502@intel.com> Date: Mon, 29 Feb 2016 11:11:22 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56C71913.10901@6wind.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/6] mempool: add external mempool manager support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Feb 2016 11:11:25 -0000 On 2/19/2016 1:30 PM, Olivier MATZ wrote: > Hi David, > > On 02/16/2016 03:48 PM, David Hunt wrote: >> Adds the new rte_mempool_create_ext api and callback mechanism for >> external mempool handlers >> >> Modifies the existing rte_mempool_create to set up the handler_idx to >> the relevant mempool handler based on the handler name: >> ring_sp_sc >> ring_mp_mc >> ring_sp_mc >> ring_mp_sc >> >> v2: merges the duplicated code in rte_mempool_xmem_create and >> rte_mempool_create_ext into one common function. The old functions >> now call the new common function with the relevant parameters. >> >> Signed-off-by: David Hunt > I think the refactoring of rte_mempool_create() (adding of > mempool_create()) should go in another commit. It will make the > patches much easier to read. > > Also, I'm sorry but it seems that several comments or question I've made > in http://dpdk.org/ml/archives/dev/2016-February/032706.html are > not addressed. > > Examples: > - putting some part of the patch in separate commits > - meaning of "rt_pool" > - put_pool_bulk unclear comment > - should we also have get_pool_bulk stats? > - missing _MEMPOOL_STAT_ADD() in mempool_bulk() > - why internal in rte_mempool_internal.h? > - why default in rte_mempool_default.c? > - remaining references to stack handler (in a comment) > - ...? > > As you know, doing a proper code review takes a lot of time. If I > have to re-check all of my previous comments, it will take even > more. I'm not saying all my comments require a code change, but in case > you don't agree, please at least explain your opinion so we can debate > on the list. > Hi Olivier, Sincerest apologies. I had intended in coming back around to your original comments after refactoring the code. I will do that now. I did take them into consideration, but I see now that I need to do further work, such as a clearer name for rt_pool, etc. I will respond to your original email. Thanks David.