From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 952F2961C for ; Wed, 2 Mar 2016 09:56:22 +0100 (CET) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 0E9CFC0003F5; Wed, 2 Mar 2016 08:56:22 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-227.ams2.redhat.com [10.36.4.227]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u228uK7f014808; Wed, 2 Mar 2016 03:56:21 -0500 To: Wenzhuo Lu , dev@dpdk.org References: <1452496044-17524-1-git-send-email-wenzhuo.lu@intel.com> <1456901135-7133-1-git-send-email-wenzhuo.lu@intel.com> <1456901135-7133-2-git-send-email-wenzhuo.lu@intel.com> From: Panu Matilainen Message-ID: <56D6AAB4.8030701@redhat.com> Date: Wed, 2 Mar 2016 10:56:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1456901135-7133-2-git-send-email-wenzhuo.lu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Subject: Re: [dpdk-dev] [PATCH v5 1/5] lib/librte_ether: change function name of tunnel port config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 08:56:22 -0000 On 03/02/2016 08:45 AM, Wenzhuo Lu wrote: > The names of function for tunnel port configuration are not > accurate. They're tunnel_add/del, better change them to > tunnel_port_add/del. > As it may be an ABI change if change the names directly, the > new functions are added but not remove the old ones. The old > ones will be removed in the next release after an ABI change > announcement. > > Signed-off-by: Wenzhuo Lu > --- > app/test-pmd/cmdline.c | 6 +++-- > examples/tep_termination/vxlan_setup.c | 2 +- > lib/librte_ether/rte_ethdev.c | 45 ++++++++++++++++++++++++++++++++++ > lib/librte_ether/rte_ethdev.h | 18 ++++++++++++++ > 4 files changed, 68 insertions(+), 3 deletions(-) > [...] > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 16da821..f1f96c1 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h [...] > @@ -3403,6 +3415,9 @@ rte_eth_dev_rss_hash_conf_get(uint8_t port_id, > int > rte_eth_dev_udp_tunnel_add(uint8_t port_id, > struct rte_eth_udp_tunnel *tunnel_udp); > +int > +rte_eth_dev_udp_tunnel_port_add(uint8_t port_id, > + struct rte_eth_udp_tunnel *tunnel_udp); > > /** > * Detete UDP tunneling port configuration of Ethernet device > @@ -3420,6 +3435,9 @@ rte_eth_dev_udp_tunnel_add(uint8_t port_id, > int > rte_eth_dev_udp_tunnel_delete(uint8_t port_id, > struct rte_eth_udp_tunnel *tunnel_udp); > +int > +rte_eth_dev_udp_tunnel_port_delete(uint8_t port_id, > + struct rte_eth_udp_tunnel *tunnel_udp); > > /** > * Check whether the filter type is supported on an Ethernet device. > You need to add these functions to rte_ether_version.map in order to export them. - Panu -