From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmatilai@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id C49AD1396
 for <dev@dpdk.org>; Tue,  8 Mar 2016 09:54:51 +0100 (CET)
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
 (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
 by mx1.redhat.com (Postfix) with ESMTPS id 3C407B1CA0;
 Tue,  8 Mar 2016 08:54:51 +0000 (UTC)
Received: from sopuli.koti.laiskiainen.org (vpn1-4-52.ams2.redhat.com
 [10.36.4.52])
 by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u288soUm018789; Tue, 8 Mar 2016 03:54:50 -0500
To: Jianfeng Tan <jianfeng.tan@intel.com>, dev@dpdk.org
References: <1453661393-85704-1-git-send-email-jianfeng.tan@intel.com>
 <1457085957-115339-1-git-send-email-jianfeng.tan@intel.com>
From: Panu Matilainen <pmatilai@redhat.com>
Message-ID: <56DE9359.1090705@redhat.com>
Date: Tue, 8 Mar 2016 10:54:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1457085957-115339-1-git-send-email-jianfeng.tan@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27
Subject: Re: [dpdk-dev] [PATCH] eal: add option --avail-cores to detect
	lcores
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Mar 2016 08:54:52 -0000

On 03/04/2016 12:05 PM, Jianfeng Tan wrote:
> This patch adds option, --avail-cores, to use lcores which are available
> by calling pthread_getaffinity_np() to narrow down detected cores before
> parsing coremask (-c), corelist (-l), and coremap (--lcores).
>
> Test example:
> $ taskset 0xc0000 ./examples/helloworld/build/helloworld \
> 		--avail-cores -m 1024
>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Hmm, to me this sounds like something that should be done always so 
there's no need for an option. Or if there's a chance it might do the 
wrong thing in some rare circumstance then perhaps there should be a 
disabler option instead?

Or am I just missing something?

	- Panu -