From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 68D0F2BCD for ; Wed, 9 Mar 2016 11:46:32 +0100 (CET) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id E681CC0AC343; Wed, 9 Mar 2016 10:46:31 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-189.ams2.redhat.com [10.36.4.189]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u29AkUEh010787; Wed, 9 Mar 2016 05:46:31 -0500 To: David Hunt , dev@dpdk.org References: <1455634095-4183-1-git-send-email-david.hunt@intel.com> <1457517037-71693-1-git-send-email-david.hunt@intel.com> <1457517037-71693-5-git-send-email-david.hunt@intel.com> From: Panu Matilainen Message-ID: <56DFFF06.3080209@redhat.com> Date: Wed, 9 Mar 2016 12:46:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457517037-71693-5-git-send-email-david.hunt@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 Subject: Re: [dpdk-dev] [PATCH v3 4/4] mempool: add in the RTE_NEXT_ABI for ABI breakages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2016 10:46:32 -0000 On 03/09/2016 11:50 AM, David Hunt wrote: > This patch is for those people who want to be easily able to switch > between the new mempool layout and the old. Change the value of > RTE_NEXT_ABI in common_base config file I guess the idea here is to document how to switch between the ABIs but to me this reads as if this patch is supposed to change the value in common_base. Of course there's no such change included (nor should there be) here, but the description could use some fine-tuning perhaps. > > v3: Updated to take re-work of file layouts into consideration > > v2: Kept all the NEXT_ABI defs to this patch so as to make the > previous patches easier to read, and also to imake it clear what > code is necessary to keep ABI compatibility when NEXT_ABI is > disabled. Maybe its just me, but: I can see why NEXT_ABI is in a separate patch for review purposes but for final commit this split doesn't seem right to me. In any case its quite a large change for NEXT_ABI. In any case, you should add a deprecation notice for the oncoming ABI break in 16.07. - Panu -