From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <david.hunt@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6D9BD2BA9 for <dev@dpdk.org>; Wed, 9 Mar 2016 12:30:59 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 09 Mar 2016 03:30:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,311,1455004800"; d="scan'208";a="920102603" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.220.68]) ([10.237.220.68]) by fmsmga001.fm.intel.com with ESMTP; 09 Mar 2016 03:30:57 -0800 To: Panu Matilainen <pmatilai@redhat.com>, dev@dpdk.org References: <1455634095-4183-1-git-send-email-david.hunt@intel.com> <1457517037-71693-1-git-send-email-david.hunt@intel.com> <1457517037-71693-5-git-send-email-david.hunt@intel.com> <56DFFF06.3080209@redhat.com> From: "Hunt, David" <david.hunt@intel.com> Message-ID: <56E00971.8040905@intel.com> Date: Wed, 9 Mar 2016 11:30:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56DFFF06.3080209@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 4/4] mempool: add in the RTE_NEXT_ABI for ABI breakages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 09 Mar 2016 11:30:59 -0000 Hi Panu, On 3/9/2016 10:46 AM, Panu Matilainen wrote: > On 03/09/2016 11:50 AM, David Hunt wrote: >> This patch is for those people who want to be easily able to switch >> between the new mempool layout and the old. Change the value of >> RTE_NEXT_ABI in common_base config file > > I guess the idea here is to document how to switch between the ABIs > but to me this reads as if this patch is supposed to change the value > in common_base. Of course there's no such change included (nor should > there be) here, but the description could use some fine-tuning perhaps. > You're right, I'll clarify the comments. v4 due soon. >> >> v3: Updated to take re-work of file layouts into consideration >> >> v2: Kept all the NEXT_ABI defs to this patch so as to make the >> previous patches easier to read, and also to imake it clear what >> code is necessary to keep ABI compatibility when NEXT_ABI is >> disabled. > > Maybe its just me, but: > I can see why NEXT_ABI is in a separate patch for review purposes but > for final commit this split doesn't seem right to me. In any case its > quite a large change for NEXT_ABI. > The patch basically re-introduces the old (pre-mempool) code as the refactoring of the code would have made the NEXT_ABI additions totally unreadable. I think this way is the lesser of two evils. > In any case, you should add a deprecation notice for the oncoming ABI > break in 16.07. > Sure, I'll add that in v4. > - Panu - > Thanks for the comments, Regards, David.