From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 328542BBC for ; Thu, 10 Mar 2016 13:25:09 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 10 Mar 2016 04:25:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,315,1455004800"; d="scan'208";a="667020472" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.48]) ([10.237.221.48]) by FMSMGA003.fm.intel.com with ESMTP; 10 Mar 2016 04:25:07 -0800 To: Panu Matilainen , dev@dpdk.org References: <2e7fcffec863b7f60cf62707b3be3dd81a5de991.1457607217.git.pmatilai@redhat.com> From: Ferruh Yigit Message-ID: <56E167A2.2070807@intel.com> Date: Thu, 10 Mar 2016 12:25:06 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <2e7fcffec863b7f60cf62707b3be3dd81a5de991.1457607217.git.pmatilai@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/3] scripts: avoid editing defconfig_* files in validate-abi.sh X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 12:25:09 -0000 On 3/10/2016 10:53 AM, Panu Matilainen wrote: > The defconfig_* files are templates which are not supposed to be > edited, and doing so tends to leave unwanted cruft behind. Edit > the "working copy" config instead, which is the intended DPDK way. > > Signed-off-by: Panu Matilainen > --- > scripts/validate-abi.sh | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/scripts/validate-abi.sh b/scripts/validate-abi.sh > index f094582..ea60639 100755 > --- a/scripts/validate-abi.sh > +++ b/scripts/validate-abi.sh > @@ -90,11 +90,11 @@ cleanup_and_exit() { > # Make sure we configure SHARED libraries > # Also turn off IGB and KNI as those require kernel headers to build > fixup_config() { > - sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET > - sed -i -e"$ a\CONFIG_RTE_NEXT_ABI=n" config/defconfig_$TARGET > - sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET > - sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET > - sed -i -e"$ a\CONFIG_RTE_KNI_KMOD=n" config/defconfig_$TARGET > + sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" $TARGET/.config > + sed -i -e"$ a\CONFIG_RTE_NEXT_ABI=n" $TARGET/.config > + sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" $TARGET/.config > + sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" $TARGET/.config > + sed -i -e"$ a\CONFIG_RTE_KNI_KMOD=n" $TARGET/.config > } > Since working .config copy updated, is there a benefit to save and restore the original .config file (if exists)? And is "git reset --hard" still required in the script? Thanks, ferruh