From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 594582BCE for ; Thu, 10 Mar 2016 13:30:00 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id D58796316E; Thu, 10 Mar 2016 12:29:59 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-209.ams2.redhat.com [10.36.4.209]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2ACTwUo010481; Thu, 10 Mar 2016 07:29:59 -0500 To: Ferruh Yigit , dev@dpdk.org References: <56E16701.5060502@intel.com> From: Panu Matilainen Message-ID: <56E168C6.3060802@redhat.com> Date: Thu, 10 Mar 2016 14:29:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E16701.5060502@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 10 Mar 2016 12:29:59 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 3/3] scripts: ignore self-generated directories in validate-abi startup check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 12:30:00 -0000 On 03/10/2016 02:22 PM, Ferruh Yigit wrote: > On 3/10/2016 10:53 AM, Panu Matilainen wrote: >> When doing multiple runs of validate-abi.sh, the git status check >> will more often than not unnecessarily fail with "Working directory not >> clean" error because of the compat_result and compile target directories >> from the previous run. Filter out the self-generated directories >> when checking. >> >> Signed-off-by: Panu Matilainen >> --- >> scripts/validate-abi.sh | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/scripts/validate-abi.sh b/scripts/validate-abi.sh >> index ea60639..a21f883 100755 >> --- a/scripts/validate-abi.sh >> +++ b/scripts/validate-abi.sh >> @@ -163,8 +163,7 @@ log "INFO" "against DPDK DSOs built from version $TAG2." >> log "INFO" "" >> >> # Check to make sure we have a clean tree >> -git status | grep -q clean >> -if [ $? -ne 0 ] >> +if [ $(git status --porcelain | grep -vE "($TARGET|compat_reports)" | wc -l) -ne 0 ] >> then >> log "WARN" "Working directory not clean, aborting" >> cleanup_and_exit 1 >> > Hi Panu, > > This check catches untracked files too, does it makes sense to limit > error only to modified files (local or staged)? I did ponder about that, untracked files seem mostly harmless in this picture but erred on the side of caution. > > This also prevents specific "compat_reports" folder check. > > And of course mentioned change requires "git clean -fd" removed, or > replaced with "make clean" Sorry, I dont understand you mean by these two comments. - Panu - > Thanks, > ferruh >