From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 0ACCF2935 for ; Thu, 10 Mar 2016 14:28:34 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 818847DCD1; Thu, 10 Mar 2016 13:28:33 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-209.ams2.redhat.com [10.36.4.209]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2ADSVfT017962; Thu, 10 Mar 2016 08:28:32 -0500 To: Aaron Conole , dev@dpdk.org References: <1456426121-21423-1-git-send-email-aconole@redhat.com> <1456426121-21423-6-git-send-email-aconole@redhat.com> From: Panu Matilainen Message-ID: <56E1767F.6040307@redhat.com> Date: Thu, 10 Mar 2016 15:28:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1456426121-21423-6-git-send-email-aconole@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Subject: Re: [dpdk-dev] [PATCH 5/8] drivers/net/ixgbe: Fix vlan filter missing brackets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 13:28:34 -0000 On 02/25/2016 08:48 PM, Aaron Conole wrote: > The ixgbe vlan filter code has an if check with an incorrect whitespace. > > Signed-off-by: Aaron Conole > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c > index 3e6fe86..2e1c3ad 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -4258,10 +4258,11 @@ ixgbe_set_pool_vlan_filter(struct rte_eth_dev *dev, uint16_t vlan, > if (ixgbe_vmdq_mode_check(hw) < 0) > return -ENOTSUP; > for (pool_idx = 0; pool_idx < ETH_64_POOLS; pool_idx++) { > - if (pool_mask & ((uint64_t)(1ULL << pool_idx))) > + if (pool_mask & ((uint64_t)(1ULL << pool_idx))) { > ret = hw->mac.ops.set_vfta(hw,vlan,pool_idx,vlan_on); > if (ret < 0) > return ret; > + } > } > > return ret; > Acked-by: Panu Matilainen Seems really obvious but cc'd the ixgbe maintainers too. - Panu -