From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmatilai@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id DF0DD29B6
 for <dev@dpdk.org>; Thu, 10 Mar 2016 14:29:49 +0100 (CET)
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
 (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
 by mx1.redhat.com (Postfix) with ESMTPS id 6568BDF211;
 Thu, 10 Mar 2016 13:29:49 +0000 (UTC)
Received: from sopuli.koti.laiskiainen.org (vpn1-4-209.ams2.redhat.com
 [10.36.4.209])
 by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u2ADTmmn018706; Thu, 10 Mar 2016 08:29:48 -0500
To: Aaron Conole <aconole@redhat.com>, dev@dpdk.org
References: <1456426121-21423-1-git-send-email-aconole@redhat.com>
 <1456426121-21423-7-git-send-email-aconole@redhat.com>
From: Panu Matilainen <pmatilai@redhat.com>
Message-ID: <56E176CB.3030404@redhat.com>
Date: Thu, 10 Mar 2016 15:29:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1456426121-21423-7-git-send-email-aconole@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.39]); Thu, 10 Mar 2016 13:29:49 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH 6/8] drivers/net/e1000/igb: Signed left shift
 operator
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2016 13:29:50 -0000

On 02/25/2016 08:48 PM, Aaron Conole wrote:
> Tell the compiler to use an unsigned constant for the config shifts.
>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
>   drivers/net/e1000/igb_pf.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c
> index 1d00dda..afe80f5 100644
> --- a/drivers/net/e1000/igb_pf.c
> +++ b/drivers/net/e1000/igb_pf.c
> @@ -172,8 +172,8 @@ int igb_pf_host_configure(struct rte_eth_dev *eth_dev)
>   	E1000_WRITE_REG(hw, E1000_VT_CTL, vtctl);
>
>   	/* Enable pools reserved to PF only */
> -	E1000_WRITE_REG(hw, E1000_VFRE, (~0) << vf_num);
> -	E1000_WRITE_REG(hw, E1000_VFTE, (~0) << vf_num);
> +	E1000_WRITE_REG(hw, E1000_VFRE, (~0U) << vf_num);
> +	E1000_WRITE_REG(hw, E1000_VFTE, (~0U) << vf_num);
>
>   	/* PFDMA Tx General Switch Control Enables VMDQ loopback */
>   	if (hw->mac.type == e1000_i350)
>
Acked-by: Panu Matilainen <pmatilai@redhat.com>

CC'd the e1000 maintainer too.

	- Panu -