From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jianfeng.tan@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 77A132BCE
 for <dev@dpdk.org>; Thu, 10 Mar 2016 19:28:41 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga103.jf.intel.com with ESMTP; 10 Mar 2016 10:23:32 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,316,1455004800"; d="scan'208";a="63715034"
Received: from tanjianf-mobl.ccr.corp.intel.com (HELO [10.255.25.114])
 ([10.255.25.114])
 by fmsmga004.fm.intel.com with ESMTP; 10 Mar 2016 10:23:31 -0800
To: Bruce Richardson <bruce.richardson@intel.com>
References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com>
 <1457551895-12077-1-git-send-email-jianfeng.tan@intel.com>
 <1457551895-12077-5-git-send-email-jianfeng.tan@intel.com>
 <20160310145004.GC18264@bricha3-MOBL3> <20160310145136.GD18264@bricha3-MOBL3>
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Message-ID: <56E1BBA3.1040007@intel.com>
Date: Fri, 11 Mar 2016 02:23:31 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160310145136.GD18264@bricha3-MOBL3>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 04/11] pmd/enic: add dev_ptype_info_get
 implementation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2016 18:28:42 -0000

Hi Bruce,

On 3/10/2016 10:51 PM, Bruce Richardson wrote:
> On Thu, Mar 10, 2016 at 02:50:04PM +0000, Bruce Richardson wrote:
>> On Thu, Mar 10, 2016 at 03:31:28AM +0800, Jianfeng Tan wrote:
>>> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>>> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>>> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>>> ---
>>>   drivers/net/enic/enic_ethdev.c | 17 +++++++++++++++++
>>>   1 file changed, 17 insertions(+)
>>>
>> I get compile errors when I apply this patch:
>>
>> == Build drivers/net/enic
>>    CC enic_ethdev.o
>> /home/bruce/next-net/dpdk-next-net/drivers/net/enic/enic_ethdev.c:57:17: error: ‘enicpmd_recv_pkts’ used but never defined [-Werror]
>>   static uint16_t enicpmd_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
>>                      ^
>>   compilation terminated due to -Wfatal-errors.
>>
> Sorry, forgot other details to reproduce. This error I see with gcc 5.3 on Fedora 23.

That's strange, I tested in VM + Fedora 23 + GCC 5.3.1, and I did not 
see this error. (I cannot find a GCC 5.3.0 package for now). Maybe need 
more investigation.

Thanks,
Jianfeng

>
> /Bruce