From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmatilai@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id C67FF2BEF
 for <dev@dpdk.org>; Fri, 11 Mar 2016 10:39:00 +0100 (CET)
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
 (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
 by mx1.redhat.com (Postfix) with ESMTPS id 3B521627CA;
 Fri, 11 Mar 2016 09:39:00 +0000 (UTC)
Received: from sopuli.koti.laiskiainen.org (vpn1-5-162.ams2.redhat.com
 [10.36.5.162])
 by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u2B9cw6B031825; Fri, 11 Mar 2016 04:38:59 -0500
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <9127451bf67ce08532a327cb66aefbcf7ed5b39f.1457687628.git.pmatilai@redhat.com>
 <7728480.8SZanX4UKp@xps13>
From: Panu Matilainen <pmatilai@redhat.com>
Message-ID: <56E29232.8070500@redhat.com>
Date: Fri, 11 Mar 2016 11:38:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <7728480.8SZanX4UKp@xps13>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.38]); Fri, 11 Mar 2016 09:39:00 +0000 (UTC)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: crypto pmds can only be built if
 librte_cryptodev is enabled
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Mar 2016 09:39:01 -0000

On 03/11/2016 11:28 AM, Thomas Monjalon wrote:
> 2016-03-11 11:13, Panu Matilainen:
>> If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled,
>> build of any crypto pmds will fail because of the missing dependency.
>> This has been present for a while now but hidden until the addition
>> of null_crypto since all the other crypto pmds have been disabled
>> by default.
>
> Good catch, thanks.
>
>> +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
>>  DIRS-y += crypto
>> +endif
>
> Why not
> DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto ?

Just because old habits ... and ... you know :)

Should I send a new version or can you fix that up when committing?

	- Panu -