From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jianfeng.tan@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id C0AEA530C
 for <dev@dpdk.org>; Tue, 15 Mar 2016 02:42:06 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga103.fm.intel.com with ESMTP; 14 Mar 2016 18:42:05 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,337,1455004800"; d="scan'208";a="764171649"
Received: from shwdeisgchi083.ccr.corp.intel.com (HELO [10.239.67.193])
 ([10.239.67.193])
 by orsmga003.jf.intel.com with ESMTP; 14 Mar 2016 18:42:04 -0700
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,
 "Richardson, Bruce" <bruce.richardson@intel.com>
References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com>
 <1457941376-15852-1-git-send-email-jianfeng.tan@intel.com>
 <1457941376-15852-2-git-send-email-jianfeng.tan@intel.com>
 <56E6F176.80304@intel.com>
Cc: helin.zhang@intel.com, konstantin.ananyev@intel.com,
 "adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Message-ID: <56E7686B.2020509@intel.com>
Date: Tue, 15 Mar 2016 09:42:03 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <56E6F176.80304@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v8 01/11] ethdev: add API to query supported
 packet types
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Mar 2016 01:42:07 -0000

Hi,

On 3/15/2016 1:14 AM, Ferruh Yigit wrote:
> On 3/14/2016 7:42 AM, Jianfeng Tan wrote:
>> Add a new API rte_eth_dev_get_supported_ptypes to query what packet types
>> can be filled by given already started device (or its pmd rx burst function
>> has already been decided).
>>
>> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>> ---
> <...>
>
>> +DPDK_16.04 {
>> +	rte_eth_dev_get_supported_ptypes;
> Other script files tends to put a blank line before function names.

Thank you for reminding.

>
>> +
>> +	local: *;
> This line is not required.

Yes, actually, this leads to compiling error when 
CONFIG_RTE_BUILD_SHARED_LIB=y.

Bruce, do you mind fix these two issues when applying the code (if 
there's no other issue)? Thanks.

Jianfeng

>
>> +} DPDK_2.2;
>>