From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f177.google.com (mail-pf0-f177.google.com [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id 200842C48 for ; Mon, 21 Mar 2016 06:41:57 +0100 (CET) Received: by mail-pf0-f177.google.com with SMTP id n5so251850475pfn.2 for ; Sun, 20 Mar 2016 22:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=71VJn4cYaifnIIoNhH4vuJWql5TlUvXAhRmf4/8Ir5g=; b=paKwQcP2LfawChxJaxPOwmIXbCHunQnM2J/0LsXpsQaBi/tbJyCKPbtHELyv3pcc/1 7gdg1i35Tn0rDADA9ggdozh/Kez9Am+QwPYpHm+sLBuUAYRXFLwEfUqR1u7eVR9zefxh 1rTazE5TDcSCti449iOEr3jPc0GaPxLMjli+fASmszMTTrJHlY5VdUEJmUNrUDZah9Bb Iikj8qmwTGTqC5FL3FjeSRd35BHUVtob3UkG5/5KofEIaYfn4m+beWMrKAQc/CgnbkuO EEpkkZnFttTEIhKg7qEjE0jM3NwEgDT2oLS6QhCw+2M7zDFqSz1v9Viq7TDoOC5IVjDB a6sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=71VJn4cYaifnIIoNhH4vuJWql5TlUvXAhRmf4/8Ir5g=; b=ROucGGACA8oBrtJDLgJkhOw6fXyXFsbRG9b5mc6TGDVn46Jz3QAx1gs4bTy8nApcaE kQmZc6Nux0qgEN6/KmIamO6glTPmYOZdWbmM4RQmQKgEok/1okgTPbkUSoRY2jjoPUvW 5rcjv5HkP0UfeeZKUf0ZTtZw4xJy3S72JN6sE/deZbtQdVouk8Pg16iBCOoRqf9VsxKz vcFa08cezfL+r4IcuWfnap5K/SzQta55rituRwleJqLRpjUsmBfZylSFNJLFC3H7fjYV MHsMorlwSDuCd0WUDxSAGBa6R8miesPyLSSUawoelcrQusiBTQks6irCgJMRnsf0SRVy NAbg== X-Gm-Message-State: AD7BkJLJhGnoOi8v+/VNtzPT+0FVrBeo2e+kjubDx7/prNnWolnhuy+352kmCFLBcfRtEw== X-Received: by 10.98.17.132 with SMTP id 4mr42756876pfr.16.1458538916541; Sun, 20 Mar 2016 22:41:56 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id ll7sm37139346pab.6.2016.03.20.22.41.55 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 20 Mar 2016 22:41:55 -0700 (PDT) To: Bruce Richardson References: <1457316434-19128-3-git-send-email-mukawa@igel.co.jp> <1458030701-11487-3-git-send-email-mukawa@igel.co.jp> <20160318122702.GA12932@bricha3-MOBL3> Cc: dev@dpdk.org, ann.zhuangyanying@huawei.com From: Tetsuya Mukawa Message-ID: <56EF89A2.1040603@igel.co.jp> Date: Mon, 21 Mar 2016 14:41:54 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160318122702.GA12932@bricha3-MOBL3> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v12 2/2] vhost: Add VHOST PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 05:41:57 -0000 On 2016/03/18 21:27, Bruce Richardson wrote: > On Tue, Mar 15, 2016 at 05:31:41PM +0900, Tetsuya Mukawa wrote: >> The patch introduces a new PMD. This PMD is implemented as thin wrapper >> of librte_vhost. It means librte_vhost is also needed to compile the PMD. >> The vhost messages will be handled only when a port is started. So start >> a port first, then invoke QEMU. >> >> The PMD has 2 parameters. >> - iface: The parameter is used to specify a path to connect to a >> virtio-net device. >> - queues: The parameter is used to specify the number of the queues >> virtio-net device has. >> (Default: 1) >> >> Here is an example. >> $ ./testpmd -c f -n 4 --vdev 'eth_vhost0,iface=/tmp/sock0,queues=1' -- -i >> >> To connect above testpmd, here is qemu command example. >> >> $ qemu-system-x86_64 \ >> >> -chardev socket,id=chr0,path=/tmp/sock0 \ >> -netdev vhost-user,id=net0,chardev=chr0,vhostforce,queues=1 \ >> -device virtio-net-pci,netdev=net0,mq=on >> >> Signed-off-by: Tetsuya Mukawa >> Acked-by: Ferruh Yigit >> Acked-by: Yuanhan Liu >> Acked-by: Rich Lane >> Tested-by: Rich Lane > Hi Tetsuya, > > I hope to get this set merged for RC2 very soon. Can you provide an update for > the nic overview.rst doc listing out the features of this new PMD. If you want, > you can provide it as a separate patch, that I will merge into this one for you > on apply to next-net. > > If you do decide to respin this patchset with the extra doc, please take into > account the following patchwork issues also - otherwise I'll also fix them on > apply: > > WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const > #364: FILE: drivers/net/vhost/rte_eth_vhost.c:56: > +static const char *valid_arguments[] = { It seems this is false positive. So I will leave it. Regards, Tetsuya