From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 7A07D2C0B
 for <dev@dpdk.org>; Mon, 21 Mar 2016 12:48:27 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga101.jf.intel.com with ESMTP; 21 Mar 2016 04:48:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,371,1455004800"; d="scan'208";a="941758579"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.55])
 ([10.237.220.55])
 by fmsmga002.fm.intel.com with ESMTP; 21 Mar 2016 04:48:26 -0700
To: Panu Matilainen <pmatilai@redhat.com>, dev@dpdk.org
References: <233492f10ac71dd9f6902eaa4bca425febc5d2c0.1458560038.git.pmatilai@redhat.com>
 <27d49a881875edbfdacbf8f621d38c3927a95881.1458560038.git.pmatilai@redhat.com>
Cc: thomas.monjalon@6wind.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <56EFDF88.2040309@intel.com>
Date: Mon, 21 Mar 2016 11:48:24 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <27d49a881875edbfdacbf8f621d38c3927a95881.1458560038.git.pmatilai@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 2/2] mk: fix two more missing libm
	dependencies
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Mar 2016 11:48:27 -0000

On 3/21/2016 11:33 AM, Panu Matilainen wrote:
> Commit e86a699cf6b1 missed two further libm dependencies: ceil() used by
> librte_meter is typically inlined so the missing dependency does not
> actually cause failures, and librte_pmd_nfp is not built by default
> so its easy to miss.
> 
> This causes duplicates in LDLIBS in many configurations so its vital
> they are removed before passing to linker.
> 
> Fixes: e86a699cf6b1 ("mk: fix shared library dependencies on libm and librt")
> 
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>

Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>