From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id AA6A22BE4 for ; Thu, 24 Mar 2016 13:25:54 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id u125so10176088wmg.1 for ; Thu, 24 Mar 2016 05:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=3nsKUc0N3+RX8Wg+iO5ZyCSQYhynHO/8CXF2FhOM8eM=; b=zBCuU9HXdr9g+VKlo1PIb1MGdBDc/iMXYZEV71O5op6HByBH2zSJrAeGH9KinWlgu7 SHsF8hW3m6p4ZnmT7O17Htq3JGLoVuAWRUOcZkLTj9Qhywy/+BfnI37sTUzjMpegQRZX hEB1rhdud5UOxfCGLrVwMiUaIDwXVKboWp8Ki4iFEAucS8VTxCRQZP4l8JjYPKrMJrVC BiRamfbaEexwpMnklCJ9NQPk9Jr1gibB8TgHi04O9mghP+dXPplNn83Joa/KKO91gn48 4qHDh+t2QrtPM6C0xzA+UBWaxpPDpOUgqG9NfFpQSqOP143UvQYok9Xsg2JjY/4lr/sq LOlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=3nsKUc0N3+RX8Wg+iO5ZyCSQYhynHO/8CXF2FhOM8eM=; b=bPRhuML6RD0zJ79fYqFMghk/97nZUYOa9kPGT3y1wE0k6RxO5EKAH2TKTm/l698o/H 8wmlzkCKxKR1HsMaic3GAcPrH62hqQxtVVhWA4B1bYr4cFjleGLk1O9g4o23sq7FuDG2 zyjU+TYWWSovkR9XR9iOYS0vwYqLhuFV0sWQvAW3gqn4dNoRiHmpTldgkQnqe95HiHma MmOIClnRYykdQwQFqCv2oSRQeM/U1aIy/L8vKAEmZQodlcrV1Mc6CxwoLDpnJ31OHcGy eJFVWZ4ft5vBUMBAkx+BtxuB7yVMJVtaR/DUtU3yLIVbxeqCRrjDPbZXnxqCvD9XFAap /IVw== X-Gm-Message-State: AD7BkJIfr1/8oeVTodh5NM89ir1x+qdtpbXi2nLmj4A23WDuNtYxptygjZCtoyRfPk5MbwtZ X-Received: by 10.194.186.170 with SMTP id fl10mr10783419wjc.29.1458822354564; Thu, 24 Mar 2016 05:25:54 -0700 (PDT) Received: from [192.168.0.10] (was59-1-82-226-113-214.fbx.proxad.net. [82.226.113.214]) by smtp.gmail.com with ESMTPSA id gk4sm7140639wjd.7.2016.03.24.05.25.53 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 24 Mar 2016 05:25:53 -0700 (PDT) To: Bruce Richardson References: <1458576484-28211-1-git-send-email-olivier.matz@6wind.com> <20160324122043.GC13728@bricha3-MOBL3> Cc: dev@dpdk.org, adrien.mazarguil@6wind.com From: Olivier Matz Message-ID: <56F3DCCF.3@6wind.com> Date: Thu, 24 Mar 2016 13:25:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160324122043.GC13728@bricha3-MOBL3> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mlx4: use dummy rxqs when a non-pow2 number is requested X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2016 12:25:54 -0000 Hi Bruce, On 03/24/2016 01:20 PM, Bruce Richardson wrote: >> @@ -734,12 +734,12 @@ dev_configure(struct rte_eth_dev *dev) >> } >> if (rxqs_n == priv->rxqs_n) >> return 0; >> - if ((rxqs_n & (rxqs_n - 1)) != 0) { >> - ERROR("%p: invalid number of RX queues (%u)," >> - " must be a power of 2", >> + if (!rte_is_power_of_2(rxqs_n)) { >> + WARN("%p: number of RX queues (%u), must be a" >> + " power of 2: remaining queues will be inactive", > > I'm not sure how clear this warning message is. To the reader there are no > extra "remaining" queues referred to, as it's not stated that the driver is > allocating extra queues. How about e.g.: > > WARN("%p: number of RX queues on device must by a power of 2. Allocating %u > queues, of which %u will be active. Remaining queues will be inactive"...) > You're right, I'll send a v2 with a clearer message. Regards, Olivier