From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 1E5BC6C9C
 for <dev@dpdk.org>; Thu, 31 Mar 2016 13:22:15 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga102.fm.intel.com with ESMTP; 31 Mar 2016 04:22:15 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,422,1455004800"; d="scan'208";a="945179201"
Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.221.8])
 ([10.237.221.8])
 by orsmga002.jf.intel.com with ESMTP; 31 Mar 2016 04:22:14 -0700
From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Cc: dev@dpdk.org
References: <1459415578-3692-1-git-send-email-danielx.t.mrzyglod@intel.com>
Message-ID: <56FD0865.8090103@intel.com>
Date: Thu, 31 Mar 2016 12:22:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1459415578-3692-1-git-send-email-danielx.t.mrzyglod@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: Fix Missed Headers For
 FreeBSD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Mar 2016 11:22:16 -0000

Commit title shouldn't contain capital letters.

On 31/03/2016 10:12, Daniel Mrzyglod wrote:
> There were misssed typedef for u_char - <sys/types.h>
> There were missed network definitions - <netinet/in.h>

Something a bit more descriptive along the lines of:
     In FreeBSD, sys/types.h and netinet/in.h need to be included before 
netinet/ip.h.
> Failure #13: http://dpdk.org/ml/archives/test-report/2016-March/001896.html
>
> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
>   examples/ipsec-secgw/esp.c   | 4 +++-
>   examples/ipsec-secgw/ipsec.c | 2 +-
>   examples/ipsec-secgw/rt.c    | 1 +
>   examples/ipsec-secgw/sa.c    | 2 ++
>   examples/ipsec-secgw/sp.c    | 2 ++
>   5 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c
> index ca0fc56..7b0e04c 100644
> --- a/examples/ipsec-secgw/esp.c
> +++ b/examples/ipsec-secgw/esp.c
> @@ -33,8 +33,10 @@
>   
>   #include <stdint.h>
>   #include <stdlib.h>
> -#include <netinet/ip.h>
>   #include <sys/types.h>
> +#include <sys/socket.h>

Do we need sys/socket.h?

Sergio