From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id C45041B12D for ; Wed, 3 Apr 2019 12:36:05 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id 4so6831559wmf.1 for ; Wed, 03 Apr 2019 03:36:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=w4EgQIY3r3RqyqtLX45tBJFcPQxAZvPFIvwzXwmDGsI=; b=aAN+Re+JMMnOl2ZsxGO756qYLoUcOgeQowC8xRd8Hi6ueo5OmgZ1aJ+YnLQoz74qvv l0iuRL0y9K9yvT+5aU+Og25A6quCM+wHl7pL46A5vXeX+sJ3INrUanrhOz01r5jVA3ih qxRfOqkoF31NuDLA0b24038pprWGM2bDDkZY3DTAcAj/Fxq4z0QfJyWZsraOb3+3cj1u q4thDs/o7hYpg9aTbEzAnTICNhyjy8xh1aEOLu2Fk0DlY6pk/cXCzEgrzGHk0UNKD4Kr yszoWvWf7lhzCoyJe8SeV4pFE7QXvh7higjlq0d4AtTb8eQMXe5x6TNmunDM2y7rxoeo Y4iA== X-Gm-Message-State: APjAAAVXqO+BcEpjMz/SsvF39P7vCWR0YR3ZaMWE3r/2h2IlJ/JRp4Vp QnGSGUtoWFCYf2xDYzXDpcrWhdpa X-Google-Smtp-Source: APXvYqxt656sYd7zYGyB59OlDAKHVBMlloWsWEmhxw6N5ipWfIJ2rloDRdSUzZiUz91zhiv82T9KDQ== X-Received: by 2002:a1c:6783:: with SMTP id b125mr1579715wmc.41.1554287765372; Wed, 03 Apr 2019 03:36:05 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:250:b6ff:feb7:bd60]) by smtp.gmail.com with ESMTPSA id a11sm16468000wrx.5.2019.04.03.03.36.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Apr 2019 03:36:04 -0700 (PDT) Message-ID: <56ce5855b02d47a085a8d36451561c400f0b039c.camel@debian.org> From: Luca Boccassi To: Ye Xiaolong Cc: dev@dpdk.org, Karlsson Magnus , Topel Bjorn Date: Wed, 03 Apr 2019 11:36:03 +0100 In-Reply-To: <20190403095939.GA32340@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190402154653.711-1-xiaolong.ye@intel.com> <20190402154653.711-2-xiaolong.ye@intel.com> <20190403095939.GA32340@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2019 10:36:05 -0000 On Wed, 2019-04-03 at 17:59 +0800, Ye Xiaolong wrote: > Hi, Luca >=20 > On 04/02, Luca Boccassi wrote: > > On Tue, 2019-04-02 at 23:46 +0800, Xiaolong Ye wrote: > > > diff --git a/drivers/net/af_xdp/Makefile > > > b/drivers/net/af_xdp/Makefile > > > new file mode 100644 > > > index 000000000..8343e3016 > > > --- /dev/null > > > +++ b/drivers/net/af_xdp/Makefile > > > @@ -0,0 +1,32 @@ > > > +# SPDX-License-Identifier: BSD-3-Clause > > > +# Copyright(c) 2019 Intel Corporation > > > + > > > +include $(RTE_SDK)/mk/rte.vars.mk > > > + > > > +# > > > +# library name > > > +# > > > +LIB =3D librte_pmd_af_xdp.a > > > + > > > +EXPORT_MAP :=3D rte_pmd_af_xdp_version.map > > > + > > > +LIBABIVER :=3D 1 > > > + > > > +CFLAGS +=3D -O3 > > > + > > > +# require kernel version >=3D v5.1-rc1 > > > +CFLAGS +=3D -I$(RTE_KERNELDIR)/tools/include > > > +CFLAGS +=3D -I$(RTE_KERNELDIR)/tools/lib/bpf > >=20 > > Sorry for not noticing this before, but doesn't this require the > > full > > kernel tree rather than just the typical headers package? Requiring > > the > > full kernel tree to be available at build time will make this > > unbuildable on distros that still use makefiles, like RHEL and > > SUSE. At > > least on Debian and Ubuntu, the kernel headers packages distributed > > do > > not include the full kernel tree, only the headers, so there's no > > tools/lib or tools/include. >=20 > Currently we do have dependencies on the kernel src tree, as xsk.h > and > asm/barrier wouldn't be installed by libbpf, so before libbpf handles > these > properly, can we keep the current RTE_KERNELDIR in Makefile for now, > and mention > the dependencies in document, also suggest users to config > RTE_KERNELDIR to correct > kernel src tree if they want to use af_xdp pmd? >=20 > Something like: >=20 > dependencies: > - kernel source code (>=3D v5.1-rc1) > - build libbfp and install >=20 > Thanks, > Xiaolong asm/barrier.h is installed by the kernel headers packages so it would be fine (although not ideal) and not need the full source tree. xsk.h is a bit more worrying, as it looks like an internal header from here. Is it really necessary for external applications to use an internal- only header and a kernel header to be able to use libbpf? --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AE6F9A0679 for ; Wed, 3 Apr 2019 12:36:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 774B91B130; Wed, 3 Apr 2019 12:36:06 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id C45041B12D for ; Wed, 3 Apr 2019 12:36:05 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id 4so6831559wmf.1 for ; Wed, 03 Apr 2019 03:36:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=w4EgQIY3r3RqyqtLX45tBJFcPQxAZvPFIvwzXwmDGsI=; b=aAN+Re+JMMnOl2ZsxGO756qYLoUcOgeQowC8xRd8Hi6ueo5OmgZ1aJ+YnLQoz74qvv l0iuRL0y9K9yvT+5aU+Og25A6quCM+wHl7pL46A5vXeX+sJ3INrUanrhOz01r5jVA3ih qxRfOqkoF31NuDLA0b24038pprWGM2bDDkZY3DTAcAj/Fxq4z0QfJyWZsraOb3+3cj1u q4thDs/o7hYpg9aTbEzAnTICNhyjy8xh1aEOLu2Fk0DlY6pk/cXCzEgrzGHk0UNKD4Kr yszoWvWf7lhzCoyJe8SeV4pFE7QXvh7higjlq0d4AtTb8eQMXe5x6TNmunDM2y7rxoeo Y4iA== X-Gm-Message-State: APjAAAVXqO+BcEpjMz/SsvF39P7vCWR0YR3ZaMWE3r/2h2IlJ/JRp4Vp QnGSGUtoWFCYf2xDYzXDpcrWhdpa X-Google-Smtp-Source: APXvYqxt656sYd7zYGyB59OlDAKHVBMlloWsWEmhxw6N5ipWfIJ2rloDRdSUzZiUz91zhiv82T9KDQ== X-Received: by 2002:a1c:6783:: with SMTP id b125mr1579715wmc.41.1554287765372; Wed, 03 Apr 2019 03:36:05 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:250:b6ff:feb7:bd60]) by smtp.gmail.com with ESMTPSA id a11sm16468000wrx.5.2019.04.03.03.36.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Apr 2019 03:36:04 -0700 (PDT) Message-ID: <56ce5855b02d47a085a8d36451561c400f0b039c.camel@debian.org> From: Luca Boccassi To: Ye Xiaolong Cc: dev@dpdk.org, Karlsson Magnus , Topel Bjorn Date: Wed, 03 Apr 2019 11:36:03 +0100 In-Reply-To: <20190403095939.GA32340@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190402154653.711-1-xiaolong.ye@intel.com> <20190402154653.711-2-xiaolong.ye@intel.com> <20190403095939.GA32340@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190403103603.fGMkD2tCzY-_IP-WsqMYitvhj0BFbvMJvJiqc8OAHrs@z> On Wed, 2019-04-03 at 17:59 +0800, Ye Xiaolong wrote: > Hi, Luca >=20 > On 04/02, Luca Boccassi wrote: > > On Tue, 2019-04-02 at 23:46 +0800, Xiaolong Ye wrote: > > > diff --git a/drivers/net/af_xdp/Makefile > > > b/drivers/net/af_xdp/Makefile > > > new file mode 100644 > > > index 000000000..8343e3016 > > > --- /dev/null > > > +++ b/drivers/net/af_xdp/Makefile > > > @@ -0,0 +1,32 @@ > > > +# SPDX-License-Identifier: BSD-3-Clause > > > +# Copyright(c) 2019 Intel Corporation > > > + > > > +include $(RTE_SDK)/mk/rte.vars.mk > > > + > > > +# > > > +# library name > > > +# > > > +LIB =3D librte_pmd_af_xdp.a > > > + > > > +EXPORT_MAP :=3D rte_pmd_af_xdp_version.map > > > + > > > +LIBABIVER :=3D 1 > > > + > > > +CFLAGS +=3D -O3 > > > + > > > +# require kernel version >=3D v5.1-rc1 > > > +CFLAGS +=3D -I$(RTE_KERNELDIR)/tools/include > > > +CFLAGS +=3D -I$(RTE_KERNELDIR)/tools/lib/bpf > >=20 > > Sorry for not noticing this before, but doesn't this require the > > full > > kernel tree rather than just the typical headers package? Requiring > > the > > full kernel tree to be available at build time will make this > > unbuildable on distros that still use makefiles, like RHEL and > > SUSE. At > > least on Debian and Ubuntu, the kernel headers packages distributed > > do > > not include the full kernel tree, only the headers, so there's no > > tools/lib or tools/include. >=20 > Currently we do have dependencies on the kernel src tree, as xsk.h > and > asm/barrier wouldn't be installed by libbpf, so before libbpf handles > these > properly, can we keep the current RTE_KERNELDIR in Makefile for now, > and mention > the dependencies in document, also suggest users to config > RTE_KERNELDIR to correct > kernel src tree if they want to use af_xdp pmd? >=20 > Something like: >=20 > dependencies: > - kernel source code (>=3D v5.1-rc1) > - build libbfp and install >=20 > Thanks, > Xiaolong asm/barrier.h is installed by the kernel headers packages so it would be fine (although not ideal) and not need the full source tree. xsk.h is a bit more worrying, as it looks like an internal header from here. Is it really necessary for external applications to use an internal- only header and a kernel header to be able to use libbpf? --=20 Kind regards, Luca Boccassi