From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E455543388; Tue, 21 Nov 2023 04:36:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D34AC40298; Tue, 21 Nov 2023 04:36:41 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id D0B224025F for ; Tue, 21 Nov 2023 04:36:39 +0100 (CET) Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4SZ91x2BBWz1P6gF; Tue, 21 Nov 2023 11:33:09 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 21 Nov 2023 11:36:36 +0800 Message-ID: <56d2f890-54eb-2e2c-3b01-817a0a1c623e@huawei.com> Date: Tue, 21 Nov 2023 11:36:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 04/16] bus/vdev: verify strdup return value To: Chengwen Feng , , , Gaetan Rivet , Xueming Li , Ray Kinsella CC: References: <20231110100117.8350-1-fengchengwen@huawei.com> <20231110100117.8350-5-fengchengwen@huawei.com> From: "lihuisong (C)" In-Reply-To: <20231110100117.8350-5-fengchengwen@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm000004.china.huawei.com (7.193.23.18) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Huisong Li 在 2023/11/10 18:01, Chengwen Feng 写道: > Add verify strdup return value logic. > > Fixes: 64051bb1f144 ("devargs: unify scratch buffer storage") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > --- > drivers/bus/vdev/vdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c > index 7974b27295..05582f1727 100644 > --- a/drivers/bus/vdev/vdev.c > +++ b/drivers/bus/vdev/vdev.c > @@ -247,6 +247,10 @@ alloc_devargs(const char *name, const char *args) > devargs->data = strdup(args); > else > devargs->data = strdup(""); > + if (devargs->data == NULL) { > + free(devargs); > + return NULL; > + } > devargs->args = devargs->data; > > ret = strlcpy(devargs->name, name, sizeof(devargs->name));