From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 100E5A057C; Fri, 27 Mar 2020 15:51:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB8E71C226; Fri, 27 Mar 2020 15:51:29 +0100 (CET) Received: from smtp-3.sys.kth.se (smtp-3.sys.kth.se [130.237.48.192]) by dpdk.org (Postfix) with ESMTP id 8BED41C226 for ; Fri, 27 Mar 2020 15:51:28 +0100 (CET) Received: from smtp-3.sys.kth.se (localhost.localdomain [127.0.0.1]) by smtp-3.sys.kth.se (Postfix) with ESMTP id BE3B089E3; Fri, 27 Mar 2020 15:51:26 +0100 (CET) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-3.sys.kth.se ([127.0.0.1]) by smtp-3.sys.kth.se (smtp-3.sys.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id shy57l7zDGXv; Fri, 27 Mar 2020 15:51:26 +0100 (CET) X-KTH-Auth: barbette [2a02:a03f:4070:7c00:9497:bf60:4477:6ee1] DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kth.se; s=default; t=1585320686; bh=ghbckqY998KppiTZk+OFA/+CHucLz6NoXtUQP9ci78A=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=mMf3xa67nO8zOTy2yv3JUmHfIr1qpJj/2XgC8vqk0sMfh9KJFUcLqRWj0pk62THTL wqqrY+tMkUmlDcH6uwCBtTuXMVyhNZI1o0CWrGkVijFk5lHDPdK0WEqpOoQrhv/dQ7 LLdyL+cIcKkdBxAFnwCoiHtBEOCCMCoCaUlzggxA= X-KTH-mail-from: barbette@kth.se Received: from [IPv6:2a02:a03f:4070:7c00:9497:bf60:4477:6ee1] (unknown [IPv6:2a02:a03f:4070:7c00:9497:bf60:4477:6ee1]) by smtp-3.sys.kth.se (Postfix) with ESMTPSA id 1EB325C8B; Fri, 27 Mar 2020 15:51:24 +0100 (CET) To: Andrew Rybchenko , dev@dpdk.org Cc: orika@mellanox.com, beilei.xing@intel.com, qi.z.zhang@intel.com References: <2aa27e9f-6063-0842-8819-f6f0fd17267c@kth.se> From: Tom Barbette Message-ID: <56e1f5fc-e159-6050-0f8e-4ded401db6bb@kth.se> Date: Fri, 27 Mar 2020 15:51:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] rte_flow: Different devices have different field indianess? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Le 27/03/2020 à 15:44, Andrew Rybchenko a écrit : > On 3/27/20 5:29 PM, Tom Barbette wrote: >> Hi all, >> >> It seems rte_flow_item_eth takes its ethertype in host byte order with >> i40e, but in network byte order with mlx5. > > If so, it is definitely bug in i40e, since struct rte_flow_item_eth > defines type as rte_be16_t type. Indeed, with testpmd I would expect the first one to be the one that works: testpmd> flow create 0 ingress pattern eth type is 0x0800 / end actions mark id 5 / end port_flow_complain(): Caught PMD error type 13 (specific pattern item): cause: 0x227fd75540, Unsupported ether_type.: Invalid argument testpmd> flow create 0 ingress pattern eth type is 0x0008 / end actions mark id 5 / end Flow rule #0 created > >> Wouldn't it be nice to unify that? Else is there a way to know in which >> byte order the spec should be given? I guess that expands to all fields, >> but I only compared the ethertype field. >> >> Thanks, >> >> Tom >