Re: [dpdk-dev] [PATCH] drivers/net: set close behaviour flag at probing

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 11/12/2018 9:42 AM, Luca Boccassi wrote:
> On Sun, 2018-11-11 at 23:46 +0100, Thomas Monjalon wrote:
>> The ethdev flag RTE_ETH_DEV_CLOSE_REMOVE is set for drivers
>> having migrated to the new behaviour of rte_eth_dev_close().
>>
>> As any other flag, it can be useful to know about its value
>> as soon as the port is probed.
>> Unfortunately, it was set inside the close operation,
>> just before being erased by memset() in rte_eth_dev_release_port().
>> The flag assignment is moved to the probing stage, so it can
>> be checked by the application in order to anticipate the behaviour.
>>
>> Fixes: 42603bbdb58e ("net/mlx5: release port on close")
>> Cc: ophirmu@mellanox.com
>> Fixes: 6c99085d972b ("net/vmxnet3: fix hot-unplug")
>> Cc: bluca@debian.org
>> Fixes: 4d7877fde2ef ("net/ena: remove resources when port is being
>> closed")
>> Cc: mk@semihalf.com
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>> ---
>>  drivers/net/ena/ena_ethdev.c         | 11 ++++++-----
>>  drivers/net/mlx5/mlx5.c              |  7 ++-----
>>  drivers/net/vmxnet3/vmxnet3_ethdev.c |  9 +++------
>>  3 files changed, 11 insertions(+), 16 deletions(-)
> 
> Acked-by: Luca Boccassi <bluca@debian.org>
> 
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.