From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF9BEA00C5; Thu, 2 Jul 2020 12:21:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39E291D73A; Thu, 2 Jul 2020 12:21:23 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5F26A1D6BF for <dev@dpdk.org>; Thu, 2 Jul 2020 12:21:21 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id E9CFE5C004E; Thu, 2 Jul 2020 06:21:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 02 Jul 2020 06:21:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= ZcsK90vPk0VwOCpDSczfKYe2Fn1hsvZpClgxQi2KKQU=; b=EV/eDCYLuTJnw5LR Emym5PWqx9YdARuu04+1TF0eyKzWYyTSQ+aPzxwJ8CEHao9mBeTh7QiJ1JDK2EDV U/NpXIrR+g1qHiDbtA48y8jyFgLkAJAtnMTlMkua+ithJa2rwhMn87IFowchnttU vUW3QD719cv3n1CneecgNywpeBHOW7ryZKamybNRYpv97VNqoRzE800X2HTzojTX NX+knAgy83yyJCjmiJ9/mm/o8Q+uVOKznU5PZOQ4IWuwFxvmnjYtdwDq0Crk2qeP NGNk9XGSGk0L2M7FHgd8wWjkA2soPj8zwV9sfu5ExMfGhuZOOi7zXoNoR5zi2xnC QuZxPw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ZcsK90vPk0VwOCpDSczfKYe2Fn1hsvZpClgxQi2KK QU=; b=Lh5izKZmrYzmqqn7YiVjbjDppb9tTB/k4L7CLtA3evpwZqQ8Gn0+wuYOL G1UN9ATZpGQhiw6RRHxw3rRvez8WAkntT4T3CzHZBcIXTRT5BYnxdL6whrsDYIX+ lvEJBEqP4ImpwbDF8XtPsxLDqwW0husczSgDaKusGdCZdwipn0wXzkYyvmuivTJ9 f+H7fXX5MMlHtGpAO86Zc5vL6nECEI24FEAcPdlD1KdHYmVO6BAEBibWy4JX3uk5 cODPB/wG+INkepm42GDsHdXAACFnszYiCv2ycRiaRywYxY4siqYfwtuZjLoXi41l B2lcyNYdF/yG7FuXscQgy2qNbEmSQ== X-ME-Sender: <xms:H7X9XmgViBlx95GE_TXOgLfVoyxu2Da5kDxN1iIvkMj1nUbGp_rD9w> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrtdeggddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: <xmx:H7X9XnCpAlawRiarbOwXa6FJFPLdwhtVdw1AO8yNfaC2dZZZXXwhTQ> <xmx:H7X9XuEc_U1pBFcUsyjc6Rh1kF4ZxSz74YvoZH9jlwZaHjCdflfFJA> <xmx:H7X9XvTdBp-nLJTFJzK9fDuAmGOI9en5f1MWCi3CixMnbSMcDjbjVA> <xmx:H7X9XsozWH_QYmSO756HrMIGAKO0oB1o6woX_5x2d9eV568CVZaBNg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C62FD3060074; Thu, 2 Jul 2020 06:21:18 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Bruce Richardson <bruce.richardson@intel.com>, Jerin Jacob <jerinjacobk@gmail.com> Cc: dpdk-dev <dev@dpdk.org>, David Marchand <david.marchand@redhat.com>, Nithin Dabilpuram <ndabilpuram@marvell.com> Date: Thu, 02 Jul 2020 12:21:17 +0200 Message-ID: <5709908.s6xYseIpxj@thomas> In-Reply-To: <CALBAE1NjkSUvYhN7yFBJ1iU2z-T=043=8QtmYc5WC=4LGmRoPw@mail.gmail.com> References: <20200701180507.2850094-1-thomas@monjalon.net> <20200702091752.GB611@bricha3-MOBL.ger.corp.intel.com> <CALBAE1NjkSUvYhN7yFBJ1iU2z-T=043=8QtmYc5WC=4LGmRoPw@mail.gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] build: remove special handling for node library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 02/07/2020 11:53, Jerin Jacob: > On Thu, Jul 2, 2020 at 2:48 PM Bruce Richardson > <bruce.richardson@intel.com> wrote: > > > > On Wed, Jul 01, 2020 at 08:05:06PM +0200, Thomas Monjalon wrote: > > > What is the point of adding librte_node a second time separately? > > > > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > > > --- > > > > I suspect that this is a hangover from when we did not explicitly > > link_whole all DPDK libs. > > Yes. The constructor functions are not getting linked if there is NO > dependency from this library. OK, so I can change the commit log to explain that it is not needed anymore because we link whole, including register.