From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 4EAD24B79 for ; Fri, 15 Apr 2016 09:34:16 +0200 (CEST) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1aqyIQ-000508-6M; Fri, 15 Apr 2016 09:36:06 +0200 To: "Wiles, Keith" , "dev@dpdk.org" References: <1457540381-20274-1-git-send-email-olivier.matz@6wind.com> <1460629199-32489-1-git-send-email-olivier.matz@6wind.com> <1460629199-32489-15-git-send-email-olivier.matz@6wind.com> Cc: "Richardson, Bruce" , "stephen@networkplumber.org" From: Olivier Matz Message-ID: <57109971.4030800@6wind.com> Date: Fri, 15 Apr 2016 09:34:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 14/36] mempool: store physaddr in mempool objects X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2016 07:34:16 -0000 On 04/14/2016 05:40 PM, Wiles, Keith wrote: >> Store the physical address of the object in its header. It simplifies >> rte_mempool_virt2phy() and prepares the removing of the paddr[] table >> in the mempool header. >> >> Signed-off-by: Olivier Matz >> --- >> lib/librte_mempool/rte_mempool.c | 17 +++++++++++------ >> lib/librte_mempool/rte_mempool.h | 11 ++++++----- >> 2 files changed, 17 insertions(+), 11 deletions(-) >> >> diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c >> index 839b828..b8e46fc 100644 >> --- a/lib/librte_mempool/rte_mempool.c >> +++ b/lib/librte_mempool/rte_mempool.c >> @@ -132,19 +132,22 @@ static unsigned optimize_object_size(unsigned obj_size) >> typedef void (*rte_mempool_obj_iter_t)(void * /*obj_iter_arg*/, >> void * /*obj_start*/, >> void * /*obj_end*/, >> - uint32_t /*obj_index */); >> + uint32_t /*obj_index */, >> + phys_addr_t /*physaddr*/); > > What is the reason to comment out the variable names, if no reason I would suggest we remove the comment marks and leave the var names. I just kept the initial style here. Anyway this code is removed later in the series. See "mempool: simplify xmem_usage". Olivier