From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE08EA00C2; Mon, 31 Oct 2022 20:01:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66A1240685; Mon, 31 Oct 2022 20:01:28 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 2A78C40223 for ; Mon, 31 Oct 2022 20:01:27 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 1647E3200946; Mon, 31 Oct 2022 15:01:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 31 Oct 2022 15:01:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1667242882; x= 1667329282; bh=Sqiu42WVuXGXGSp9cN+hqG9jZxv4DClZzV5d9abZkCI=; b=s njAMxbw9OBOlFwSYBmTRmKtEuqUpCvfDWxuw3OQBBqyENDXJQKO8dp6oKvhdQgOn xAHudUR5WbsIz+CyeHR6YqjVKBc/dMWxwJZZsGlIYR4VrsMNhWgUp1Z97XSgWayF 8NsGdK2oYA8oRFtzqRHnqbQ7xJPy1H76sSdemZCQkLRlfp/SX8BAyZcmBgBcg6PN +kZ3fRg6O7O3E+OC+kL4bF5GLTEazct04ORjjZnmJBIO/x2t11e6AkTu3l010usK GJ64XM5Ka0ejOyyk3wK0Rjiwrtr+vkhQdSmo7/slwvAXUpcTpNhV6vzkOKkpt+pE fsLT8cuFPG3rTXcb6oizw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1667242882; x= 1667329282; bh=Sqiu42WVuXGXGSp9cN+hqG9jZxv4DClZzV5d9abZkCI=; b=Z IXHcQZudqbti6lFYXoDfN/7QriGI+PInhJEPjRvYHeMaBplWFV4fAvTBS+CraIt5 X5x8TLTqR7NXGqo1Mu52HZSmYVAgcR7rLNxiChDvbqOoYG0j6QM1f/JfVTcyFs0H EPLp/RRb6gJ9Om17t4xI0qSkRl5yv75ESWMqr/0Zzgdc0TPKft73yEuy8rIEY0a3 LAEfiBmwm3QQfVsnJZ1/5x85lezeNh8nfO2TwPnthMHwD9zRan6lYqKCDFxpa2ER cC8gw/lDZKZ8xsS7cgvnoUy490SXZha9lXyTy5TQjlP1ZbJ7cqNKyG+SsyJw4/l7 5kK1Q6nUEKAcWCXlX6BhQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudefgdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 31 Oct 2022 15:01:18 -0400 (EDT) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= Cc: Honnappa.Nagarahalli@arm.com, ohilyard@iol.unh.edu, lijuan.tu@intel.com, kda@semihalf.com, bruce.richardson@intel.com, dev@dpdk.org Subject: Re: [PATCH v6 00/10] dts: ssh connection to a node Date: Mon, 31 Oct 2022 20:01:12 +0100 Message-ID: <5711158.zQ0Gbyo6oJ@thomas> In-Reply-To: <20221013103517.3443997-1-juraj.linkes@pantheon.tech> References: <20221013103517.3443997-1-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org I was about to merge this series, and after long thoughts, it deserves a bit more changes. I would like to work with you for a merge in 22.11-rc3. 13/10/2022 12:35, Juraj Linke=C5=A1: > All the necessary code needed to connect to a node in a topology with > a bit more, such as basic logging and some extra useful methods. There is also some developer tooling, and some documentation. [...] > There are configuration files with a README that help with setting up > the execution/development environment. I don't want to merge some doc which is not integrated in the doc/ directory. It should be in RST format in doc/guides/dts/ I can help with this conversion. > The code only connects to a node. You'll see logs emitted to console > saying where DTS connected. >=20 > There's only a bit of documentation, as there's not much to document. > We'll add some real docs when there's enough functionality to document, > when the HelloWorld testcases is in (point 4 in our roadmap below). What > will be documented later is runtime dependencies and how to set up the DTS > control node environment. >=20 [...] > .editorconfig | 2 +- > .gitignore | 9 +- Updating general Python guidelines in these files should be done separately to get broader agreement. > MAINTAINERS | 5 + You can update this file in the first patch. > devtools/python-checkpatch.sh | 39 ++ Let's postpone the integration of checkpatch. It should be integrated with the existing checkpatch. > devtools/python-format.sh | 54 +++ > devtools/python-lint.sh | 26 ++ Let's postpone the integration of these tools. We need to discuss what is specific to DTS or not. > doc/guides/contributing/coding_style.rst | 4 +- It is not specific to DTS. > dts/.devcontainer/devcontainer.json | 30 ++ > dts/Dockerfile | 39 ++ Not sure about Docker tied to some personal choices. > dts/README.md | 154 ++++++++ As said above, it should in RST format in doc/guides/dts/ > dts/conf.yaml | 6 + > dts/framework/__init__.py | 4 + > dts/framework/config/__init__.py | 100 +++++ > dts/framework/config/conf_yaml_schema.json | 65 ++++ > dts/framework/dts.py | 68 ++++ > dts/framework/exception.py | 57 +++ > dts/framework/logger.py | 114 ++++++ > dts/framework/remote_session/__init__.py | 15 + > .../remote_session/remote_session.py | 100 +++++ > dts/framework/remote_session/ssh_session.py | 185 +++++++++ > dts/framework/settings.py | 119 ++++++ > dts/framework/testbed_model/__init__.py | 8 + > dts/framework/testbed_model/node.py | 63 ++++ > dts/framework/utils.py | 31 ++ > dts/main.py | 24 ++ > dts/poetry.lock | 351 ++++++++++++++++++ A lot of dependencies look not useful in this first series for SSH connecti= on. > dts/pyproject.toml | 55 +++ > 27 files changed, 1723 insertions(+), 4 deletions(-)