From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A580643CA5; Thu, 14 Mar 2024 12:44:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4699642EC8; Thu, 14 Mar 2024 12:43:31 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2067.outbound.protection.outlook.com [40.107.96.67]) by mails.dpdk.org (Postfix) with ESMTP id 9404342EB2 for ; Thu, 14 Mar 2024 12:43:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kb/glNcv5drEK5m+vMwG8qZrP4d8EVXEdEtjRC+7re73ZxRqKhllionOkPgCxiYNpLIvqcQNSgVndOS78fAkBqYxswpFDzj7fExNr4nHTc4kvjHQgzAqr2iW2jm636zcDL8Ki7Oh7j71VK/cbeygT+Xi/RzUEUXW/e9Bs+J3I0NTFOLPDMX4+QIgy/bmtsQJKc0Qy+IT/ufTClYGaXJIY2CEu403wn4Gp7Uf3v9E8ovGhYu8WqgCg3v1zjXJkx7msOSWVrwnTx3DXJubLdNSjfhKWRwpmIkp0Kk6n491Tqvqway3WmHvNgUqCZe5ossbUXePiykT2q6rmtlhUv8ndw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9dzkWE0FqVSldKoutHN4ryzWnfGONLttbzR3W4OaqnA=; b=OJpSJNjBRMMPII9u5aQgMduiVbUFOmtbJsC9DLyBX2S0Z1mqwFHpsj4zAqJt5NfISF/StnD9t4wo/sEuG8h6ymY02JCK8HsSrC6Z4h1IZyG3JMQp8ED6qzXRE2cwK/EZnsMrogXhNOA8J58AHkKMJYGSsgBXXcETiwmAjwE7emY5+0Jn+TqN5HJOZ4xbTiNb5Cph9NDPyk2CcZ2OV56FDV8B9242cNZIIfCpYNdxtIFAqO+xxcb1881DFpANn4ELUBUbuMj4a807pqIEHBQBFl6yZ1QqpIux59WTeGGBiNKEdTPkcvOcpwQ9986y/+HSSiAStSP3aEpAX4wxxHvSGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9dzkWE0FqVSldKoutHN4ryzWnfGONLttbzR3W4OaqnA=; b=SW8/RpVuMDaz/3Jd8pnVez7RF1YTBk/uoxSmFv1ook8f8hd3odK7tJOEr2TcJMKi+S06WEChxdkMc3m5gub3/WWwrRHRCCzp8LpiX6kuBAV4R2e/4RSBmeL2h61N5y9c2OhZSQlvG9nn6OWnMBdusNNa+1Esb7bATZskISPSK0I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB6692.namprd12.prod.outlook.com (2603:10b6:806:270::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Thu, 14 Mar 2024 11:43:22 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024 11:43:22 +0000 Message-ID: <57112f25-21f7-4c3c-a963-a7ae9890fa1a@amd.com> Date: Thu, 14 Mar 2024 11:43:18 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] app/testpmd: enhance getopt_long usage Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: Aman Singh , Yuying Zhang References: <20240308144841.3615262-1-david.marchand@redhat.com> <20240314091708.1542769-1-david.marchand@redhat.com> <20240314091708.1542769-7-david.marchand@redhat.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240314091708.1542769-7-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0370.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB6692:EE_ X-MS-Office365-Filtering-Correlation-Id: cab8bf7b-84c9-4d15-96ab-08dc441bf382 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rhdbQgyUhY0BuLVmxOXIyDWaPO9E9unbnTW9pyZ5dcRemy7x/v42zGgDym0q99zhO/++s8qzZLLkemKxDjd46gl6ZWlOJBTzf9VmrPtbkZciaTeb6JZLMdwRcEmVQRDND3O2pbz/j2vWw/KHUcxt7fEPfUmmoc8RYiX0GmxgIlPRjYfueXlMr+pF9CGK6snrPKVEU7UeedXpQlDOttyU+4oW4l7n//B18kxkHfAjM9mspPFW4UFq0sWAhBq9IQnBoSTQwYsxFB8KAN/NpHKvvfsX1LMcAZO6PojeqQ99sYRyy9gIvev705GldLBFktyUQdn/+FLa3kTW5VCob0WokV7i2etL6BpMuVSsSh/Ib+RDBq086ldLyBe6YY+J69ZWTOKdA+0WxFdEvGe/2sX6dHnNIhu0nEJE2BvsoFk0KOuVzvIW+mPCGHqJbaJ71YStTcAFwxSWzwM+J7GVcRYmEpSGhLhk5b40V26b3GDSx6ZnD2GBw6zBIgi13woFDWGU00IUzcwY7ZY0Mo6PEkMx3nkc1yAUZIqsBa9gKdv89LoNgVblWL4jxoXBCqRg0tSP19m5571JNsTDIWw7TeBsDqJy2bbEjd5FLcySqNpr8dFJobTXoOth6lpcYz08SjsinP6/G+gNOaSHQ9Hkkj+8YC/2x2w9p13yV3ZpF5X4RMo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFNEd3Z6RExqcHFHaU5yS2U4MzZjRWZ2a2d3RG1PcEpRU0ZydmJMZE1PMFFi?= =?utf-8?B?MFAxRHpyYVl6Z3lsMDFsMlllWXo3eGZMSjNwbHZmbE9yZFJkZzZLMlFlMEpo?= =?utf-8?B?Q3hWVFQyNmtwMVIxSUZMYUlwSVE0YWNyelFUZFJua3dGOU9xSTBodXZXSi9H?= =?utf-8?B?VEE1Tk4xeUs2NkhlUWRmU1FSN3k4TzFZNnVib29yMVJSVzNNenhqWHBPS1ZT?= =?utf-8?B?dTArblozbENYMityRnYzcTRxK2hOVER5M1huNXFsTzU2UnVtcVVGYjFuQkFq?= =?utf-8?B?MEFlZXZRYTFueWJmc1NTTUpENGpnNGhoejUxRnZwazg1T2g1Y2htRlZwcmo3?= =?utf-8?B?Tk9sWFVkbU9Jamh6ZG5OOE54K0Zta1Zqd0Y1OFh2UkNXM2FZODI2RnBzeDdQ?= =?utf-8?B?TGhOKytSbzY5SmxUeG1rTVQvNjU0NlExTUp3YjcrWUhvYkdJSXNLc1RKYjlU?= =?utf-8?B?ekhuK3M2d1ppWkhaa2JLenhLTEpsMnBkWjRvMWYvdFNMSG1hdDNwb1VmNy80?= =?utf-8?B?bkkxVVF2YVNuSGxFakQwSXlvUzZGMkp0MDBUUjZrZ0NJZXhvZU94ODhjTThj?= =?utf-8?B?UC9BSndPclZCU01vLzVxVERucTJ1WXRqK1U2NVdwcDRRK3hTODRUeWQ1Rkk3?= =?utf-8?B?VktaMktXemh1ODZaUDJ6ays5YjRsK1AvVm44RzJteGxGaXJsbDZVTDcwQzcr?= =?utf-8?B?cExkZWI5MVpCRUFtekcwaElMdER0T21UbjlEQ2xabURPS2pNYVBxZ092N2ZP?= =?utf-8?B?VEV2NzFnb3NzNmI5TGFaRFR5Y0RJdEVRQjdxWjJBWkxPSnc0Yi9rVVF0QWdt?= =?utf-8?B?MWRzL05Ja0llV2NjRzZnbXRZTytpZ0FzcDdMckJLZVhIRU5mWHozN0hKb3FB?= =?utf-8?B?dGhUNnNmSnQ5Y2FlRmxsNlpwQk9zLzhmeHJSbjdHaEpjL0pJZUdyeWh5RHRC?= =?utf-8?B?TFR5Vk9FYzk3R2U4TEJXQkJiZHNmcE9YbDloVWVZbHdyU3dwb2NGZnRFdzNN?= =?utf-8?B?cy94cWt5NFA3WW0xanhxNXRpT0k4ajE3aVUrVjh5bGh6TUUxeUlCTlFaYThJ?= =?utf-8?B?OENvdWNuYXdaNVBEMkFITnF2NG4yVnBiemdZaGhLUVNTTXZpS2x5L1ZBUEpQ?= =?utf-8?B?RkhmalJRQVZqMmtrYVRBc2V5S0F6WGxpZmVjNGtUNWxsWkZ2QnRGTlQzUVVs?= =?utf-8?B?M2Y2dlg2SWtjOFpUbDlpakFLVVk3WWlCWFQ2Vjd1NjFabXIvaHAxenpiSmcy?= =?utf-8?B?bm5tZ0o0RG0rSzBBV3pCWURjR2hydUFrcWtHZTVzMlEzYWJuRjhCYXVZNUlm?= =?utf-8?B?QzZmcXUvUGYvUUFrbEVMUXlla1hoYjh0MUtUVUhtUERBeDF1V0N2Mzc3RTk3?= =?utf-8?B?N21zYUE1dVNGbUV6QXVtMXdwVUxDSWk4RTViZnorTHBvWEhCQ2Q3R0kxTVh6?= =?utf-8?B?WmFXa0lGWHJjTFNrQ2ZoalBBQ2dkTzFhc1MzUndzTlIyeVcvZ1JIRUlJbFFw?= =?utf-8?B?UzBYNE54UVl0VlB2RXlDZ2dtSFlGa0Z4cTJsTTc3SEhmMFNVUW9nTkNhbnV5?= =?utf-8?B?Yi9aZUdtM2NHVGJaczBSbU9PUS9VdHZ2eFk0dit6eVJRU0hXZnVHbDhpZERR?= =?utf-8?B?YkFod290Zk5XVXJTbG5Ka3h4WURpUEgyWWE5eHIrZzJrbmU3blFRbmJSQ21G?= =?utf-8?B?dXZsME5KMk12c0FPL3lCa2tPS0Y5cGh4MEhHUXNkTXV5a1lINXIzTHVsRkdO?= =?utf-8?B?T3dVWlZOcit4T0VvUHE5RWs3RnVSYVQ1Rm94TDFuMkVpdEFuTmNVenAxOFdy?= =?utf-8?B?UnI1bjhKcXFQUnFBWk0xSVpCK3hETTRvam9RK29VSlptYzZFVXRzMWVBUkpP?= =?utf-8?B?d0ZSMFYwZDVzWVFVR1YxREhRTlJzNlY5b2tQUnJadEM0S2dLbEtpLy9lT3Rz?= =?utf-8?B?RjR6OWEvOVNDU0NZVEw1TC9RbWNZM0VQb24zcG5NTjZaMVV3VVp1bHlFM3Qy?= =?utf-8?B?cWFWVVphV3c5VXQwTURGNUhIZWRBWFRsNzYwRDl6YjNvRDExcTc0ekdEeXEx?= =?utf-8?B?R0ZwOVk3K3YrUTE4aWJUekNMcFlIQTF3WjY5andaRTRwWlVMOHpReTdJcnRl?= =?utf-8?Q?FzCdZAV78QjgEmXSv4f6ZND90?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cab8bf7b-84c9-4d15-96ab-08dc441bf382 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:22.1041 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /OZeVHo00JTdy3UlZvZUh0lHp23CxW1Is7gGylPOBNzRZkm4odouCC/AH6PNKoWM X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6692 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/14/2024 9:17 AM, David Marchand wrote: > This is a cleanup similar to previous ones in EAL and examples. > Instead of using strcmp for every long options while getopt_long already > did such parsing, rely on getopt_long return value. > > Note for reviewers: this patch is best reviewed once applied locally and > displayed with git show -w. > > Signed-off-by: David Marchand > Acked-by: Ferruh Yigit